feat(generated)!: SDK surface change: Symbol "IntentOptions" was removed (+4 more)#698
Open
workos-sdk-automation[bot] wants to merge 7 commits into
Open
feat(generated)!: SDK surface change: Symbol "IntentOptions" was removed (+4 more)#698workos-sdk-automation[bot] wants to merge 7 commits into
workos-sdk-automation[bot] wants to merge 7 commits into
Conversation
…cationIntentOptions" was removed
Contributor
Greptile SummaryThis PR regenerates the Python SDK from the updated OpenAPI specification. The main changes are:
Confidence Score: 4/5Package-level model imports can fail after this update, and some additional removals are missing from the release notes.
src/workos/common/models/init.py, src/workos/common/init.py, src/workos/sso/models/init.py, and src/workos/organization_domains/models/init.py Important Files Changed
Prompt To Fix All With AIFix the following 3 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 3
src/workos/common/models/__init__.py:109
**Existing Model Exports Disappear**
This removes package-level exports for dozens of models that still exist, including `DirectoryUserState`, `EventContextActorSource`, `PipeConnectedAccountState`, and `WaitlistUserState`. Applications importing these names from `workos.common.models` or `workos.common` will now fail at import time, although the release notes announce only five unrelated removals.
### Issue 2 of 3
src/workos/sso/models/__init__.py:4
**Undocumented ConnectionOption Removal**
Removing this export and deleting its module breaks applications that import `ConnectionOption` from `workos.sso.models` or `workos.types.sso`. The changelog announces only the removal of `SSOIntentOptions`, so affected callers receive no notice or replacement guidance for this additional breaking change.
### Issue 3 of 3
src/workos/organization_domains/models/__init__.py:6
**Undocumented Stand-Alone Alias Removal**
Removing `OrganizationDomainStandAlone` breaks existing imports from `workos.organization_domains.models` and `workos.types.organization_domains`. The changelog does not list this removal or direct callers to `OrganizationDomain`, so this additional breaking API change is missing from the release notes.
Reviews (1): Last reviewed commit: "chore(generated): add release notes frag..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| @@ -109,7 +109,6 @@ | |||
| from .authenticate_response_impersonator import ( | |||
Contributor
There was a problem hiding this comment.
This removes package-level exports for dozens of models that still exist, including DirectoryUserState, EventContextActorSource, PipeConnectedAccountState, and WaitlistUserState. Applications importing these names from workos.common.models or workos.common will now fail at import time, although the release notes announce only five unrelated removals.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/workos/common/models/__init__.py
Line: 109
Comment:
**Existing Model Exports Disappear**
This removes package-level exports for dozens of models that still exist, including `DirectoryUserState`, `EventContextActorSource`, `PipeConnectedAccountState`, and `WaitlistUserState`. Applications importing these names from `workos.common.models` or `workos.common` will now fail at import time, although the release notes announce only five unrelated removals.
How can I resolve this? If you propose a fix, please make it concise.|
|
||
| from .connection import Connection as Connection | ||
| from .connection_option import * # noqa: F401,F403 | ||
| from .connection_domain import ConnectionDomain as ConnectionDomain |
Contributor
There was a problem hiding this comment.
Removing this export and deleting its module breaks applications that import ConnectionOption from workos.sso.models or workos.types.sso. The changelog announces only the removal of SSOIntentOptions, so affected callers receive no notice or replacement guidance for this additional breaking change.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/workos/sso/models/__init__.py
Line: 4
Comment:
**Undocumented ConnectionOption Removal**
Removing this export and deleting its module breaks applications that import `ConnectionOption` from `workos.sso.models` or `workos.types.sso`. The changelog announces only the removal of `SSOIntentOptions`, so affected callers receive no notice or replacement guidance for this additional breaking change.
How can I resolve this? If you propose a fix, please make it concise.| CreateOrganizationDomain as CreateOrganizationDomain, | ||
| ) | ||
| from .organization_domain_stand_alone import * # noqa: F401,F403 | ||
| from workos.common.models.organization_domain import ( |
Contributor
There was a problem hiding this comment.
Removing OrganizationDomainStandAlone breaks existing imports from workos.organization_domains.models and workos.types.organization_domains. The changelog does not list this removal or direct callers to OrganizationDomain, so this additional breaking API change is missing from the release notes.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/workos/organization_domains/models/__init__.py
Line: 6
Comment:
**Undocumented Stand-Alone Alias Removal**
Removing `OrganizationDomainStandAlone` breaks existing imports from `workos.organization_domains.models` and `workos.types.organization_domains`. The changelog does not list this removal or direct callers to `OrganizationDomain`, so this additional breaking API change is missing from the release notes.
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat(admin_portal)!: SDK surface change: Symbol "IntentOptions" was removed
feat(connect)!: SDK surface change: Symbol "ConnectedAccountDto" was removed
feat(organization_domains)!: SDK surface change: Symbol "DomainVerificationIntentOptions" was removed
feat(pipes)!: SDK surface change: Symbol "DataIntegrationCredentialsDto" was removed
feat(sso)!: SDK surface change: Symbol "SSOIntentOptions" was removed
Triggered by workos/openapi-spec@eda9449
BEGIN_COMMIT_OVERRIDE
feat(admin_portal)!: SDK surface change: Symbol "IntentOptions" was removed (#698)
feat(connect)!: SDK surface change: Symbol "ConnectedAccountDto" was removed (#698)
feat(organization_domains)!: SDK surface change: Symbol "DomainVerificationIntentOptions" was removed (#698)
feat(pipes)!: SDK surface change: Symbol "DataIntegrationCredentialsDto" was removed (#698)
feat(sso)!: SDK surface change: Symbol "SSOIntentOptions" was removed (#698)
END_COMMIT_OVERRIDE