Repository navigation
refactor(renderer)!: remove the renderMarkdown prop - #89
Merged
Merged
Conversation
CanvasView accepted renderMarkdown and put it in the canvas context, and nothing read it: text nodes have drawn through Skia since March, because a native markdown view rendered empty in the transformed canvas layer and, on macOS, native text stops drawing about 1500px from its parent's origin. #27 marked it deprecated. Its only callers, Workspace's desktop and mobile apps, stopped passing it in workspace-sh/workspace#644. BREAKING CHANGE: CanvasView no longer has a renderMarkdown prop, and the value from useCanvasContext no longer has a renderMarkdown field. A caller that still passes the prop fails typecheck; delete the prop, it had no effect. The goal the prop was for, text nodes that match a markdown document, is #88. Refs: #26, #88 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
CanvasView'srenderMarkdownprop and the matching field on the canvas context.Nothing has read it since March 2026. It was added so a host could inject its own markdown component for text nodes; within a day text moved to Skia, because the injected native view rendered empty in the transformed canvas layer and, on macOS, native text stops drawing about 1500px from its parent's origin. #27 marked the prop deprecated.
Breaking
CanvasViewno longer acceptsrenderMarkdown.useCanvasContext()no longer hasrenderMarkdown.A caller that still passes the prop fails typecheck. Delete the prop: it had no effect. Workspace's desktop and mobile apps, the only callers, stop passing it in workspace-sh/workspace#644, which lands first.
Not lost
The goal behind the prop, text nodes that draw markdown as well as a document does, is #88. A prop that returns a React element can't serve it: a native view can't be drawn into a Skia canvas.
Verification
npm run typecheck: cleannpm run lint: 0 errorsnpm test: 192 passrenderMarkdownleft insrc/src/gtknever had the prop.Refs: #26, #88
🤖 Generated with Claude Code