chore(lint): enable eqeqeq lint rule - #32
Merged
Merged
Conversation
Require strict equality (===/!==) across the codebase. Loose equality performs implicit type coercion, which hides type bugs behind surprising truthiness rules. The codebase currently has zero violations, so this is a preventive guardrail with no code changes needed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Preview deployment |
# Conflicts: # eslint.config.mjs
Member
Author
|
Resolved merge conflict against Posted by the moadim routine "Resolve conflicts on code-quality PRs (non-guiddeco)". |
Preview deployment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31
What
Enable the ESLint
eqeqeqrule as["error", "always"]ineslint.config.mjs, requiring strict equality (===/!==) throughout the codebase.Why
Loose equality (
==/!=) coerces operand types before comparing, producing surprising results that hide bugs (0 == ""→true,null == undefined→true,[] == false→true). Strict equality compares without coercion, so comparisons stay predictable and type-safe — a natural fit for a TypeScript codebase.Change
eslint.config.mjs; no other rules touched.eqeqeqviolations, so no source changes were needed — this is a preventive guardrail.Verification (local)
npm run lint→ passes (exit 0)npm run build→ passes (exit 0)cc @tupe12334 for review.
This pull request was opened by the "Add lint rule → issue + PR (owned repos + my orgs) → Slack" routine of moadim.