docs(world-id): fix on-chain action hash to use field-reduced value - #191
Merged
Merged
Conversation
- world-id/idkit/onchain-verification.mdx: change the minimal-mapping guidance for computing verify()/verifyAndExecute() args from raw action = keccak256(action) to the field-reduced action = hash_to_field(action) (keccak256(action) >> 8), and add a warning that a raw hash exceeds the BN254 scalar field and reverts with PublicInputNotInField
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
Contributor
Author
|
Follow-up style pass: tightened the wording added in the earlier commit (the |
soamdesai-tfh
force-pushed
the
docs-audit/world-id-onchain-hash-fix
branch
from
September 21, 2026 17:28
aae3b93 to
738be27
Compare
- action mapping: hash_to_field(utf8(action)) over the UTF-8 bytes of the top-level action string, matching how IDKit builds the proof's action - warning: give the Solidity form, uint256(keccak256(bytes(action))) >> 8
kchaw2005
approved these changes
Sep 23, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix invalid on-chain action hash.
world-id/idkit/onchain-verification.mdx: usehash_to_field(action)instead of rawkeccak256(action)in the verify() mapping. Warn that an unreduced hash can exceed the BN254 field and revert withPublicInputNotInField; below-field raw hashes still differ from the proof's field-reduced action.