Skip to content

[Follow-up] Configurable raw base for the academic calendar #31

Closed as not planned

Description

@FortuneCatOfSummer

Context

#29 and #30 made the SUSTech Online raw base configurable. The academic
calendar still hard-codes https://raw.githubusercontent.com/dumixthestpd/sustech-calendar/main
in src/calendar/client.ts, so sustech calendar day, sustech tis schedule,
tis ical, and other calendar-derived commands fail on networks that cannot
reach raw.githubusercontent.com.

The follow-up was suggested in #30.

Proposal

  • Add SUSTECH_CALENDAR_RAW_BASE, defaulting to the current public repository
    base, so behaviour is unchanged when unset.
  • Reuse the HTTPS base validation shared with the online layer.
  • Reject non-HTTPS values, values with embedded credentials, and values with a
    query string or fragment, with CALENDAR_RAW_BASE_INVALID.

A PR follows.

Activity

  1. FortuneCatOfSummer commented on Oct 26, 2026

    @FortuneCatOfSummer
    ContributorAuthor

    Tracked by #29 and #30; closing this follow-up to avoid a duplicate. The calendar change is in #32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions