Skip to content

Cookie database from pinned OCD, hide scores without enough data, CSP script-src-elem - #47

Merged
woutervanwijk merged 2 commits into
mainfrom
claude/audit-followup
Nov 13, 2026
Merged

woutervanwijk merged 2 commits into
mainfrom
claude/audit-followup

Conversation

@woutervanwijk

@woutervanwijk woutervanwijk commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

Follow-up to #44 (audit of the score calculations).

  • Cookie database: lib/utils/cookie_db.g.dart is now generated by tool/gen_cookie_db.dart from the pinned Open Cookie Database CSV (tool/data/, commit 7786335, 2026-11-06). The wildcard flag comes from OCD (not from a _/- suffix), the longest prefix wins, wildcards shorter than 3 characters match exactly. Hand-curated names that OCD lacks live in lib/utils/cookie_overrides.dart. 108 of the 2293 old names changed category (OCD wins). 19 cookies of social platforms are classified social by a documented rule; pixel and ad cookies stay advertising.
  • Attribution: the OCD Apache-2.0 text is registered on the app's licenses page (About → Open source licenses) and listed in THIRD_PARTY_NOTICES.md.
  • Licence: LICENSE said GPLv3 while README and About said MIT. The project is MIT (the only commit author is the copyright holder), with a note in README and About that the name and icon are not covered by the licence.
  • No score without enough data: Sovereignty shows no score or grade below 50% verified checks (SovereigntyReport.minCoverage); Cookie Privacy Lens only scores when both the Set-Cookie headers and the browser cookies were read.
  • CSP: script-src-elem / script-src-attr are evaluated per CSP3.
  • Audit report: the earlier K10 finding (quoted ; in cookie values) was wrong: RFC 6265 §5.2 splits at the first ;. A test now documents that.

Test plan

  • flutter test: 1327 passing
  • flutter analyze: only the existing deprecated_member_use infos
  • dart run tool/gen_cookie_db.dart is idempotent
  • Manual check of the Cookies and Sovereignty tabs on a real site

🤖 Generated with Claude Code

woutervanwijk and others added 2 commits November 13, 2026 09:30
…CSP script-src-elem

- Cookie database: lib/utils/cookie_db.g.dart is generated by
  tool/gen_cookie_db.dart from the pinned Open Cookie Database CSV
  (tool/data). Wildcard comes from OCD's flag, longest prefix wins,
  hand-curated names live in cookie_overrides.dart. 19 social-platform
  cookies are classified as social by a documented rule.
- Attribution: OCD Apache-2.0 text shown on the app's licenses page,
  THIRD_PARTY_NOTICES.md.
- No score without enough data: Sovereignty needs 50% of the checks
  verified; Cookie Privacy Lens needs both cookie sources.
- CSP: script-src-elem and script-src-attr fallback (CSP3).
- Audit report: K10 (quoted ';') was a false finding, RFC 6265 5.2.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
LICENSE said GPLv3 while README and the About screen said MIT. Wouter van Wijk
is the only commit author, so LICENSE now carries the MIT text. README and
About state that the name and icon are not covered by the licence.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@woutervanwijk
woutervanwijk merged commit 9c4d75c into main Nov 13, 2026
1 check passed
@woutervanwijk
woutervanwijk deleted the claude/audit-followup branch November 13, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant