Repository navigation
Audit fixes: data correctness, security and cleanup (plan 01) - #57
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…l the section Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The vsvFrame handler is untested on a real browser here (validation gate left to the controller); postMessage remains the fallback path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…bucket Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d patterns Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…connections Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Myers on lines with hunks and context, `\ No newline at end of file` markers, and a manifest `diff` state (present / exceedsLimit / notApplicable) instead of a line-N-vs-line-N comparison. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…a package Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…at app name Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…onstant Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Removed: lib/utils/page_weight.dart (resourcesBySize/ResourceSize had no users in lib/ or integration_test/) with its test, HtmlService loadServerSourceForDiff, cancelPendingHighlight (and its unused timer field), getLanguageForExtension (tests now use SourceViewerEditor.getLanguageForExtension, which the app uses). generateDescriptiveFilename moved verbatim to lib/utils/descriptive_filename.dart. Expectations changed in enhanced_language_support_test to what SourceViewerEditor returns: tsx -> typescript, h -> c, and about 190 extensions (json5, vue, svelte, kt, scss, toml, ini, ...) -> plaintext. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deleted the 177-assertion all-plaintext test; plaintext expectations moved out of the "should be supported" tests into one small fallback test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…frame bridge fallback, S2 comment, privacy wording) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
docs/superpowers/plans/2026-11-15-01-audit-fixes.md(spec:docs/audits/2026-11-15-explorer-audit.md), 17 tasks plus a final-review fix round.Data correctness
HtmlServiceintoderive/resource_matching.dart.lib/utils/site.dart, generator intool/), used by detection, sovereignty, estimates and cookies.source/diff.patchis a real unified diff (Myers), accepted bypatch.Security and privacy
PRIVACY.mdlists every third party the app contacts; sharing a package asks for confirmation first.debugPrintis silent in release builds; certificate dialog in English.sourceapp=viewsourcevibe.Quality
lib/utils/descriptive_filename.dart; onekAppVersion;avoid_printexemption limited totest/andtool/.html_service.dart5454 → 4743 lines.Verification
flutter analyzeclean;flutter test1441 passed, 1 skipped.validation/run.shon all ten sites, branch vs main: identical totals (ok 415, wrong 14, volatile 9, gap 5). One per-site difference on kvk (survey widget hosts) did not reproduce in two re-runs.Known limits / follow-ups
sourceappusers to email stat@ripe.net with the identifier.🤖 Generated with Claude Code