Repository navigation
Structure tab: page-width wireframe on full-page screenshot, reveal element in DOM tree and source - #62
Merged
Conversation
…lement in DOM tree and source - Wireframe drawn at page width (max 1000 px), centred, horizontally scrollable when wider than the tab (was shrunk to fit + 6000 px cap). - Full-page screenshot of the live browser as the wireframe background: captured at settle by scrolling viewport-by-viewport and stitching the shots (screenshot_stitch.dart); drawn opaque, structure overlay 75% transparent. Falls back to the viewport thumbnail over the first screen. - Block details sheet: "Open in DOM tree" and "Open in source" buttons that work for elements without an id too (matched by tag/id/classes plus occurrence in document order); source scrolls to the element's line. - DOM tree reveal: expands ancestors, opens the node one level, scrolls exactly to it (large finite cacheExtent during the reveal) and highlights the row like a selected line in the Source view. - Pull-to-refresh removed from all tab pages. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Structure tab improvements on top of #61:
takeScreenshotonly captures the viewport, so at page-settle the live browser is scrolled viewport-by-viewport (max 50 shots) and the shots are stitched into one tall image (lib/services/screenshot_stitch.dart); scroll position is restored. Drawn fully opaque behind the wireframe; the structure overlay is 75% transparent so the page shows through. Falls back to the viewport thumbnail over the first screen (e.g. Linux, where screenshots are unsupported).DomReveal,findNodeBySignature,lineOfSignature). Source scrolls to the element's line; DOM tree expands ancestors, opens the node one level, scrolls exactly to it (large finitecacheExtentduring the reveal so the lazy sliver builds the row) and highlights the row like a selected line in the Source view.RefreshIndicatorwrappers inHomeScreen).Verification
flutter analyzeclean.flutter test: 1678 tests pass, incl. new coverage foroccurrenceOfBlock/lineOfSignature,findNodeBySignature,stitchScreenshots, the sheet buttons, and the DOM reveal (scroll-into-view + one-level open + highlight on a tall document).Caveats
position: fixedelements repeat at seams; very tall pages are capped at 50 viewport shots.