fix: integrate raw Workshop P0 convergence - #190
Merged
Conversation
Update the canonical Workshop dependency to 0.1.2, preserve the five-artifact evidence record, and block definitive check/lint results when the parser retains opaque or unknown Workshop constructs.
Contributor
Author
|
Updated PR #190 with the published workshop-rs 0.1.2 lockfile, five-artifact evidence link, and explicit semantic-incompleteness audit. Current local rerun: standalone parse 5/5 exit 0; check/lint 5/5 reached all five lint rules, but each reports blocking workshop-semantic-incomplete diagnostics, so no silent semantic-success claim is made. |
Teakowa
marked this pull request as ready for review
August 20, 2026 18:00
Contributor
Author
|
CI run 32400375007 is green on exact head 12a1858 across Rust stable/1.85, CLI smoke, LPP, OSTW/native differentials, release gates, and Ubuntu/macOS/Windows distribution. PR is now Ready for review (non-Draft). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workshop-rs 0.1.1to0.1.2and refreshCargo.lock;SettingsNode::Raw, unknown action/value calls, andrawWorkshopActionas structured blockingworkshop-semantic-incompletediagnostics so check/lint findings cannot be presented as definitive;Validation
cargo fmt --all -- --checkcargo clippy --locked --workspace --all-targets --all-features -- -D warningscargo test --locked --workspace --all-targets --all-featuresworkshop-rs-cli parse --locale ...runs: exit 0;check --kind workshopand fivelint --kind workshopruns: all reached the five registered lint rules; semantic incompleteness was explicitly reported for every artifact.The per-artifact hashes, provenance, acquisition procedure, parse result, semantic-incompleteness counts, lint findings, and review classification are recorded in raw-workshop-p0-evidence-v1.md. The durable owning-repository manifest is workshop-rs#63.
Lint findings remain classified
uncertainwhere opaque semantics affect the relevant construct; no opaque construct is treated as silent semantic success.Dependency / tracking