Repository navigation
test: cover split, rollover and killed-process sidecars (D4-C) - #21
Merged
Merged
Conversation
Three lifecycle cases from the design's test plan: - split: shrunken size limit forces two files, each with its own sidecar and split_index 0/1; - rollover: a 2.2s gap starts a new session, so both files have complete sidecars with different generations; - no stop(): an isolated child writes and _exit()s, leaving the initial sidecar behind with complete=false and no total_bytes. The read-only directory case is dropped: the existing write-failure test already proves sidecar IO errors do not propagate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
补齐设计文档 §8 里剩下的生命周期用例。
只读目录那条（S-08）没加：现有的 write-failure 用例已经证明 sidecar 写失败不会外溢，重复覆盖收益低。
预计新增约 2.7 秒（主要来自 rollover 的 2.2 秒等待）。