Skip to content

Stop auto-reviewing ignored bookmarks - #3

Merged
ronething merged 1 commit into
mainfrom
codex/fix-unreviewed-bookmarks
Jul 26, 2026
Merged

ronething merged 1 commit into
mainfrom
codex/fix-unreviewed-bookmarks

Conversation

@ronething

Copy link
Copy Markdown
Contributor

What changed

  • stop marking shown bookmarks as reviewed after seven days
  • return bookmarks previously stored with status: "expired" to the unreviewed queue
  • preserve explicit Keep/Delete review records
  • replace the misleading expiry countdown with a status that says the bookmark is waiting for the user choice
  • update the privacy disclosure to match the stored review states

Root cause

Opening a new tab records a bookmark as shown. On later new-tab loads, the queue treated every bookmark first shown more than seven days earlier as reviewed with status: "expired", even when the user never chose Keep or Delete. Opening more tabs exposed more bookmarks to that timer, so the reviewed count grew automatically and could eventually empty the queue.

User impact

Bookmarks now remain in the review queue until the user explicitly keeps or deletes them. Existing bookmarks that were automatically expired by previous versions rejoin the queue on the next load.

Validation

  • added a regression test proving shown bookmarks remain unreviewed after eight days
  • added a migration test proving legacy expired records rejoin the queue without changing explicit kept records
  • pnpm verify (7 tests, extension build, security scan)
  • git diff --check

@ronething
ronething marked this pull request as ready for review July 26, 2026 13:39
@ronething
ronething merged commit 2d805c9 into main Jul 26, 2026
1 check passed
@ronething
ronething deleted the codex/fix-unreviewed-bookmarks branch July 26, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant