Repository navigation
Stop auto-reviewing ignored bookmarks - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
status: "expired"to the unreviewed queueRoot cause
Opening a new tab records a bookmark as shown. On later new-tab loads, the queue treated every bookmark first shown more than seven days earlier as reviewed with
status: "expired", even when the user never chose Keep or Delete. Opening more tabs exposed more bookmarks to that timer, so the reviewed count grew automatically and could eventually empty the queue.User impact
Bookmarks now remain in the review queue until the user explicitly keeps or deletes them. Existing bookmarks that were automatically expired by previous versions rejoin the queue on the next load.
Validation
pnpm verify(7 tests, extension build, security scan)git diff --check