Fix KeyError crashes: TMDB API deprecated 'casts' field, replaced by 'credits' - #260
Merged
Merged
Conversation
The TMDB API replaced 'casts' with 'credits' in append_to_response, and returns an empty 'images' dict when no language is specified. This caused KeyError crashes on 'casts', 'keywords', and 'images' during library scans. - Request 'credits' instead of 'casts' in append_to_response - Fall back to 'casts' key for backward compatibility - Only overwrite movie images if fallback images are non-empty - Use .get() with defaults on 'keywords', 'releases', and image sub-keys
|
Decision: APPROVE Issues: none Evidence:
Review Details
|
Contributor
|
thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #259
What changed
append_to_responsenow requestscreditsinstead ofcasts(TMDB API change)castskey for any backward compatibility edge cases_gather_details: only overwritesmovie['images']with the language-fallback if it is non-empty (TMDB returnsimages: {}when no language is specified)_assemble_details: uses.get()with safe defaults onkeywordsandreleases_parse_artwork: uses.get()with safe defaults on image sub-keys (posters,backdrops,logos)Why
The TMDB API silently dropped
castsfromappend_to_responseresponses in favour ofcredits, causingKeyErrorcrashes during library scans. The emptyimagesdict issue compounds this when the language-fallback request returns no images.