Repository navigation
Open
Labels
p1Important, not on the critical pathImportant, not on the critical pathstatus:unclaimedNobody owns this yet - claim itNobody owns this yet - claim ittype:decisionA choice the team must make (may become an ADR)A choice the team must make (may become an ADR)ws:docsDocs and process - ADRs, README, playbooks, testsDocs and process - ADRs, README, playbooks, tests
Description
Goal
Before Phase 1 starts, I checked the hackathon security concerns against main and NEXT.md. Phase 1 closes the big one: once 1.2 and 1.4 land, apps can't read the shell's localStorage, and #135 now tests exactly that. Three items don't have a step yet:
- SSRF through
/api/chat'sbaseUrl. Thecustomprovider passes any client-suppliedbaseUrltocreateOpenAI, and the OpenAI and DeepSeek paths accept one too (server/api/chat.post.tslines 48, 64 and 70). So the server will POST to any host a caller names, private and metadata addresses included. 3.3's blocklist ("never one without the other") is scoped to/api/proxy. Could the same check cover the chat route, or would an allowlist of known provider hosts plus a resolved-IP check forcustombe better? I can add an expected-fail spec for it, like test: Phase 1 exit check as an expected-fail e2e spec #135, if that helps. /api/chatis open: no auth, no rate limit. Since 0.2 there's no server key to drain, so the worst case is smaller, but it's still an anonymous relay. Is a network-exposed deployment in scope, or is the target localhost and self-hosting behind the host's own auth? NEXT.md's goal could be read either way, and the answer decides whether this needs a step.- VFS writes fail silently.
writeFilecatches a failedsetItemand only logs it, so the registry'spersist()never sees the error, and an install can half-write when storage is full.listFilesalso matchesapps/todoagainstapps/todo-list/…. 1.1 rewrites this interface anyway, so adding "writes reject on failure; an install is all-or-nothing; listing matches whole path segments" to 1.1's Done-when costs little now.
@r0073d-l053r @Sullux, these are yours (security review, and server/api/** and vfs.ts). @xcjs, while they're away, your call as tiebreaker.
Done when
- SSRF via the chat route's baseUrl: a step, a Done-when line, or out of scope, recorded
- an open /api/chat: deployment scope decided and recorded
- silent VFS write failures: in 1.1's Done-when, or a decision recorded
Files
NEXT.md
Depends on
(none)
Notes
(created by claude-code for @m-vawter at 2026-10-23T22:40:31Z)
Metadata
Metadata
Assignees
Labels
p1Important, not on the critical pathImportant, not on the critical pathstatus:unclaimedNobody owns this yet - claim itNobody owns this yet - claim ittype:decisionA choice the team must make (may become an ADR)A choice the team must make (may become an ADR)ws:docsDocs and process - ADRs, README, playbooks, testsDocs and process - ADRs, README, playbooks, tests
Activity