Add arrow key/dpad/controller navigation to the whole website - #198
Open
GiantWods wants to merge 10 commits into
Open
Add arrow key/dpad/controller navigation to the whole website#198GiantWods wants to merge 10 commits into
GiantWods wants to merge 10 commits into
Conversation
GiantWods
commented
Aug 13, 2026
GiantWods
commented
- controller nav should turn on automatically when controller is plugged in, idk cant test i dont have one
- unified focus ring on everything when tabbing or when you turn on arrow key navigation
- some elements refactored to work better with new navigation engine
- arrow keys in player dont seek/change volume if arrow nav is on, but navigate between icons, navigate to seekbar or volume to change those
- left tests behind so it can be tested for future updates idk, only kept tests for homescreen and stuff, removed tests for simple layouts
- idk stuff
- 6.5k lines are just tests/fixtures (all 31 are test.ts/test.tsx files) for navigation features, can be removed if u want, only 2633 lines are actual src code
Add optional directional nav engine, turns on by itself for tv browsers/gamepads Expands gamepad polling outside the player, routed through nav engine as well Also fixes several pre-existing accessibility gaps found along the way: a missing focus ring below Chromium 86, five unreachable clickables, a stray positive tabindex, leaking keyboard listeners, and a closing overlay that stayed navigable during its exit transition. Also some refactors of existing UI so they work better
Collaborator
|
@claude pls figure out idk what any of this means |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.