Skip to content

Home: the English email tag fits its card - #34

Open
Jiu-xiao wants to merge 1 commit into
devfrom
fix/en-email-tag-20261112
Open

Jiu-xiao wants to merge 1 commit into
devfrom
fix/en-email-tag-20261112

Conversation

@Jiu-xiao

Copy link
Copy Markdown
Member

On the English home page the email tag read "Email, click to copy". The tags are 64 px wide and their labels do not wrap, so the label (about 89 px) ran over the GitHub and QQ Group tags at every width where the tags are shown.

  • The English label is now "Email", matching the Chinese 邮箱.
  • The copy hint moves into the button's title: 点击复制邮箱地址 / "Click to copy the email address".
  • home.hero.tag.emailName, which no code reads, is removed from i18n/en/code.json.

Checked on a local build of both locales: at 1024, 1280 and 1440 px every tag label fits its card in both languages ("QQ Group" is the widest English label at 61 px; "Copied ✓" measures 55 px), and the email button carries the hint in each language.

The English label "Email, click to copy" was wider than the 64 px tag and
covered the GitHub and QQ Group tags next to it. The tag now reads "Email",
as the Chinese one reads 邮箱, and the copy hint moves into the button's
title in both languages. The unused home.hero.tag.emailName entry is removed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant