Repository navigation
Conversation
The English label "Email, click to copy" was wider than the 64 px tag and covered the GitHub and QQ Group tags next to it. The tag now reads "Email", as the Chinese one reads 邮箱, and the copy hint moves into the button's title in both languages. The unused home.hero.tag.emailName entry is removed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the English home page the email tag read "Email, click to copy". The tags are 64 px wide and their labels do not wrap, so the label (about 89 px) ran over the GitHub and QQ Group tags at every width where the tags are shown.
title: 点击复制邮箱地址 / "Click to copy the email address".home.hero.tag.emailName, which no code reads, is removed fromi18n/en/code.json.Checked on a local build of both locales: at 1024, 1280 and 1440 px every tag label fits its card in both languages ("QQ Group" is the widest English label at 61 px; "Copied ✓" measures 55 px), and the email button carries the hint in each language.