submodule: bump coffeecatch to f629a666 - #166
Merged
Merged
Conversation
Docs and tests only. coffeecatch.c and coffeejni.c are unchanged between the two pins, and the four objects Android builds from them hash identically on arm64-v8a and x86_64, so the shipped library is the same bytes. The header now records that a process has one alarm(): arming your own over an uncancelled watchdog replaces it, and the cancel then disarms yours. That came out of reviewing the previous bump, where the teardown path looked like it leaked the pending flag. It is a constraint rather than a defect, so the fix is what the call can promise, not the code. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the coffeecatch submodule to f629a666. Docs and tests only:
coffeecatch.candcoffeejni.care byte-identical between the two pins, and the four objects Android builds from them hash the same on arm64-v8a and x86_64, so the shipped library does not change.The header now records that a process has one
alarm(): arming your own over an uncancelled watchdog replaces it, and the cancel then disarms yours. That came out of reviewing #165, where the teardown path looked like it leaked the pending flag. It turned out to be a constraint of the single process alarm rather than a defect, so what changed is the documented promise.Three tests come with it, all of which the suite used to pass without: the watchdog is a real timer and not just a flag, a cancel owed after
COFFEE_END()survives an unrelated session on another thread, and the documented -1 return.