Bump the vendored engine to eeba324c - #167
Merged
Merged
Conversation
Engine #1376 added htsescape.c, and htstools.c calls into it. Android builds htstools.c, so the file joins Android.mk's hand-maintained source list; without it ld.lld leaves hts_unescapehttp and hts_unescapeini undefined. #1407 converted all 30 catalogs to UTF-8 and retired LANGUAGE_CHARSET, so build_strings.sh loses its charset assertion, the charset read below it, and the iconv stage they fed. The iconv goes rather than being retargeted at utf-8: macOS ships a Citrus iconv that rejects valid UTF-8. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the vendored engine to eeba324c, 43 commits past the current pin.
Two things in the tree have to move with it. The engine's new htsescape.c joins Android.mk's hand-maintained source list, because htstools.c is built on Android and calls into it; without the line ld.lld leaves hts_unescapehttp and hts_unescapeini undefined. And with all 30 catalogs now UTF-8 and LANGUAGE_CHARSET retired, tools/build_strings.sh loses its charset assertion, the charset read below it, and the iconv stage they fed. The iconv goes rather than being retargeted at utf-8, since macOS ships a Citrus iconv that rejects valid UTF-8.
The three parts land together by necessity: the assertion fires against the new catalogs, and dropping it ahead of the pin would let the old ones be read as UTF-8 and silently produce mojibake.
Not a release cut: versionCode and versionName are untouched, and the engine VERSIONID is still 3.49.23. If the freeze lands on a later engine commit, this branch takes a follow-up pointer move rather than a new PR.