Fix musical key names for F minor and D-flat major - #195
Merged
Merged
Conversation
The stream operator for `musical_key` wrote `f_minor` as "F" and `d_flat_major` as "D♭m", each dropping or gaining the minor suffix. Both collided with the name of a different key -- "F" is `f_major` and "D♭m" is `d_flat_minor` -- so neither could be told apart from its neighbour by anything reading the output. The other twenty-two entries are correct. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
mr-smidge
approved these changes
Aug 26, 2026
mr-smidge
left a comment
mr-smidge
left a comment
Contributor
There was a problem hiding this comment.
Wow, these errors were sitting here for over 3 years! LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
operator<<formusical_keywrites two keys under the wrong name:f_minorprints as "F", dropping the minor suffix — which is the name off_major.d_flat_majorprints as "D♭m", gaining one — which is the name ofd_flat_minor.In both cases the output collides with a different key in the same enum, so neither can be told apart from its neighbour by anything reading the stream. Noticed while reading real key names off a rekordbox device, where three tracks in F minor were displayed as F major.