Fix strict aliasing violation in the neon batch_bool load - #1420
Merged
serge-sans-paille merged 1 commit intoOct 1, 2026
Merged
serge-sans-paille merged 1 commit into
serge-sans-paille merged 1 commit into
Conversation
| XSIMD_INLINE batch_bool<T, A> load_unaligned(bool const* mem, batch_bool<T, A>, requires_arch<neon>) noexcept | ||
| { | ||
| uint8x8_t tmp = vreinterpret_u8_u32(vset_lane_u32(*(unsigned int*)mem, vdup_n_u32(0), 0)); | ||
| unsigned int bits; |
Contributor
There was a problem hiding this comment.
I know this wasn't in the original code, but could you set uint32_t bits instead? that would match vset_lane_u32 signature more accurately
Contributor
|
LGTM with the minor nit applied. |
The sizeof(T) == 4 overload read a `bool const*` through an `unsigned int` lvalue, which is undefined behaviour. Use memcpy instead.
domibel
force-pushed
the
neon-batch-bool-debian-1143838
branch
from
October 1, 2026 06:41
6aca092 to
c15601e
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sizeof(T) == 4 overload read a
bool const*through anunsigned intlvalue, which is undefined behaviour. Use memcpy instead.The bug was reported in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1143838