build(deps): bump three from 0.181.1 to 0.181.2 - #2281
dependabot[bot] wants to merge 2 commits into
Conversation
aa7b374 to
9dfd9e3
Compare
|
@dependabot rebase |
9dfd9e3 to
6883c3a
Compare
|
@dependabot rebase |
6883c3a to
13313e8
Compare
|
Review: !! Note on the PR description: it says 0.181.1 → 0.181.2, but the actual diff in Where three is used in this repo:
Checked the official migration guide (181→182, 182→183) against actual usage:
Verification performed, and its actual scope:
Proposed follow-up issues (not blockers for this PR):
Confirmed safe to merge |
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
Bumps [three](https://github.com/mrdoob/three.js) from 0.181.1 to 0.181.2. - [Release notes](https://github.com/mrdoob/three.js/releases) - [Commits](https://github.com/mrdoob/three.js/commits) --- updated-dependencies: - dependency-name: three dependency-version: 0.181.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
f1779a9 to
abfa04e
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
new THREE.Timer() will throw at runtime because Timer is not a top-level three export and must be imported from the addons path.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
This PR is presented as a Dependabot dependency bump for three, but it does two things: it raises the three dependency and it modifies ViewportManager.js to switch the animation loop from THREE.Clock to THREE.Timer (the Clock replacement introduced/encouraged in newer three.js releases). It fits into the ThreeEditor viewport rendering path, which drives per-frame animation updates.
Changes:
- Bump
threeinpackage.jsonandpackage-lock.json(actual target is^0.183.2, not0.181.2as the title states). - Replace
THREE.ClockwithTHREE.Timerin the viewport animation loop and feed thesetAnimationLooptimestamp intotimer.update(timestamp)before readingtimer.getDelta().
| File | Description |
|---|---|
package.json |
Updates the three dependency range (to ^0.183.2). |
package-lock.json |
Locks three to 0.183.2 with updated resolved URL/integrity. |
src/ThreeEditor/js/viewport/ViewportManager.js |
Swaps Clock for Timer in the animate loop; introduces new THREE.Timer() and timer.update(timestamp). |
Key concerns found during review:
new THREE.Timer()will throw at runtime:Timeris not a top-levelthreeexport (unlikeClock) and must be imported fromthree/examples/jsm/misc/Timer.js.- The PR title/description says
0.181.1 → 0.181.2, but the diff bumps to0.183.2, a minor-version change that also motivates the source edit.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // animations | ||
|
|
||
| const clock = new THREE.Clock(); // only used for animations | ||
| const timer = new THREE.Timer(); // only used for animations |
| "signals": "^1.0.0", | ||
| "split-grid": "^1.0.11", | ||
| "three": "^0.181.1", | ||
| "three": "^0.183.2", |


Bumps three from 0.181.1 to 0.181.2.
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)