-
Notifications
You must be signed in to change notification settings - Fork 5
dataset download eta #2351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
martastn
wants to merge
7
commits into
master
Choose a base branch
from
2350-display-estimated-time-remaining-for-simulation-dataset-download
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
dataset download eta #2351
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
dbda56d
dataset download eta
martastn 4307cf1
removed unnecessary export
martastn 418dfd1
text explaining displayed time
martastn 5638000
fix bar animation after page refresh
martastn 3d7db73
extract ETA formatting into time util
martastn 873bcca
move dataset download ETA computation to dataset download manager + f…
martastn 2a1ac89
fix download speed measured over a single poll interval + grow ETA wh…
martastn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| export interface SpeedHistoryEntry { | ||
| /** Progress at the last recorded change, as a fraction in the 0..1 range. */ | ||
| lastProgressFraction: number; | ||
| /** Epoch timestamp in milliseconds of the last recorded progress change. */ | ||
| lastTimestampMs: number; | ||
| /** Smoothed download speed, expressed as progress fraction per second. */ | ||
| speedFractionPerSecond: number; | ||
| } | ||
|
|
||
| export type SpeedHistory = Record<string, SpeedHistoryEntry>; | ||
|
|
||
| /** Weight of the newest speed sample- the higher, the faster but jumpier the reaction. */ | ||
| export const SPEED_SMOOTHING = 0.1; | ||
|
|
||
| export function nextSpeedHistoryEntry( | ||
| prev: SpeedHistoryEntry | undefined, | ||
| progressFraction: number, | ||
| timestampMs: number | ||
| ): SpeedHistoryEntry { | ||
| if (!prev) { | ||
| return { | ||
| lastProgressFraction: progressFraction, | ||
| lastTimestampMs: timestampMs, | ||
| speedFractionPerSecond: 0 | ||
| }; | ||
| } | ||
|
|
||
| const elapsedSeconds = (timestampMs - prev.lastTimestampMs) / 1000; | ||
| const progressFractionDelta = progressFraction - prev.lastProgressFraction; | ||
|
|
||
| if (progressFractionDelta < 0) { | ||
| return { ...prev, lastProgressFraction: progressFraction, lastTimestampMs: timestampMs }; | ||
| } | ||
|
|
||
| if (progressFractionDelta === 0 || elapsedSeconds <= 0) { | ||
| return prev; | ||
| } | ||
|
|
||
| const instantSpeedFractionPerSecond = progressFractionDelta / elapsedSeconds; | ||
| const speedFractionPerSecond = | ||
| prev.speedFractionPerSecond === 0 | ||
| ? instantSpeedFractionPerSecond | ||
| : prev.speedFractionPerSecond * (1 - SPEED_SMOOTHING) + | ||
| instantSpeedFractionPerSecond * SPEED_SMOOTHING; | ||
|
|
||
| return { | ||
| lastProgressFraction: progressFraction, | ||
| lastTimestampMs: timestampMs, | ||
| speedFractionPerSecond | ||
| }; | ||
| } | ||
|
|
||
| export function estimateSecondsRemaining( | ||
| entry: SpeedHistoryEntry, | ||
| progressFraction: number, | ||
| timestampMs: number | ||
| ): number | undefined { | ||
| const remainingFraction = 1 - progressFraction; | ||
|
|
||
| if (entry.speedFractionPerSecond <= 0 || remainingFraction <= 0) { | ||
| return undefined; | ||
| } | ||
|
|
||
| const stalledSeconds = Math.max(0, (timestampMs - entry.lastTimestampMs) / 1000); | ||
|
|
||
| return remainingFraction / entry.speedFractionPerSecond + stalledSeconds; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add comment why this was added