Bind YDB temporal values using native JDBC types - #265
Merged
Merged
Conversation
KirillKurdyukov
marked this pull request as ready for review
September 14, 2026 13:35
Collaborator
Author
|
PR #265 is ready for review, position1/1. Head Exact source and runtime-log reviews approved; JDK25 compile/test-compile passed14production+5test. Fresh ordinary full CI:307 total,222 passed,85 skipped,0 failures/errors. Original date/timestamp and CHAR negative contracts remain covered. No second review mention is sent. The separate mixed-schema diagnostic remains unrun because the local Docker/Colima environment is unavailable. |
KirillKurdyukov
marked this pull request as draft
September 14, 2026 13:41
KirillKurdyukov
marked this pull request as ready for review
September 14, 2026 14:01
KirillKurdyukov
marked this pull request as draft
September 14, 2026 14:47
KirillKurdyukov
marked this pull request as ready for review
September 14, 2026 14:56
KirillKurdyukov
marked this pull request as draft
September 14, 2026 15:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Select temporal parameter writers from each existing column's native JDBC TYPE_NAME instead of relying on forceSignedDatetimes. Bind values and NULL with the matching vendor SQL type code. New Trino date and timestamp(3)/(6) columns use Date32 and Timestamp64.
YdbColumnMappings contains the six temporal SQL-code constants, native date/timestamp column mappings and write functions; YdbClient selects mappings and DDL types. Date writers pass epoch days, Datetime writers pass epoch seconds, and Timestamp writers use Instant to preserve microseconds. Remove the connector's forceSignedDatetimes override and retain standard readers. The explicit unsupported time/zoned-timestamp filter preserves selection across all 29 upstream Trino483 datasets, including the negative CHAR contract.
Head
f0639955bd9fb0ec403963a78717f42432c97601: five files, +105/-46 = 151 changed lines. The extraction preserves all six constant values and all five method bodies. JDK25 compilation passed (14 production and 5 test sources). Independent exact source and runtime-log reviews approved.Fresh ordinary full CI passed on Temurin25.0.4:307 tests,222 passed,85 skipped,0 failures/errors. Tested merge
0d26aea64dbd14770d2393dff243303b9d185e2bcombines this exact head with base469d559cf9210ee3babe8fdcc01b1988035fedd1. Three original date sets, two timestamp(3), two timestamp(6) and CHAR negative case remain covered. Workflow unchanged.Existing-column metadata reaches ordinary INSERT, predicates, direct UPDATE and MERGE INSERT. Standard generic MERGE UPDATE/DELETE handles omit native JDBC types; described driver paths may recover the target type. Mixed-family and non-UTC compatibility remain unverified: the local Docker API and default Colima VM SSH are unavailable, so the separate mixed-schema diagnostic has not run. Legacy Date range behavior is unchanged.