Repository navigation
Verify production CTAS with the default write setting - #267
Closed
KirillKurdyukov wants to merge 3 commits into
Closed
KirillKurdyukov wants to merge 3 commits into
KirillKurdyukov wants to merge 3 commits into
Conversation
KirillKurdyukov
changed the title
KirillKurdyukov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify production adapter CTAS with
insert.non-transactional-insert.enabled=false: successful table creation and duplicate-key failure cleanup. Document the separate limitation of ordinary INSERT in this default mode and the direct, non-transactional setting with its partial-write risk.The diagnostic INSERT error test has been removed at the user's request. The retained test covers CTAS and cleanup only. No production code, capabilities, workflows, or skips change.
Validation for
23238991856156897f33107258e8d549c9cb7364: JDK 25 test compilation and diff checks passed; independent GPT-6 Astra/high review found no issues. Full ordinary CI36577034854 passed: 313 total, 228 passed, 85 skipped, zero failures/errors. The retained default-write-mode class passed both its CTAS test and framework check.The INSERT limitation was observed against real YDB in diagnostic CI36566451734: Trino 483's
CREATE TABLE tmp AS SELECT ... WHERE 0 = 1staging statement was rejected atAS. This PR does not implement transactional INSERT or expand inherited capabilities.