Prepare Trino 484 adapter upgrade - #271
Draft
KirillKurdyukov wants to merge 1 commit into
Draft
KirillKurdyukov wants to merge 1 commit into
KirillKurdyukov wants to merge 1 commit into
Conversation
Target release 484 and adapt the merge-sink provider memory context. Keep the existing JOIN path and connector behavior declarations. Release artifacts are not published yet. Local 484-SNAPSHOT validation passes 24 unit/API tests; integration setup is blocked by missing Docker. Document these limits and keep the upgrade as a draft until release CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Separate version upgrade after #270, based on canonical main
94955bb79c10fc9469cab2d13a422a8c0fa93a4f.YdbPageSinkProvider.createMergeSinkto the new trailingMemoryContextargument.handling and non-transactional MERGE contract. No prototype engine changes
or expression-JOIN parser are included.
Why this is a draft
As of 2026-10-01, both
Maven Central
and Trino releases still
publish 483 as the latest release. The default POM deliberately targets the
future 484 release, not a moving snapshot.
Release dependency resolution and normal release CI are therefore blocked.
This PR must remain draft until 484 artifacts are published and the complete
connector CI passes without a version override. No tests or CI checks are
disabled to hide this condition.
The actual CI run
for head
d059566d06dfc551d81ebc9cb9ed9effbe55a99dconfirms this blocker:dependency:go-offlinefails withCould not find artifact io.trino:trino-base-jdbc:jar:484 in central.The test step is not reached; this is not a passing CI run.
Preliminary validation
Java: Temurin 25.0.2. API reference: upstream
8d58343762f56a7d0f13b799f5521ddca6fbcfff,484-SNAPSHOT.Checks use locally built snapshot dependencies in a separate Maven repository.
The unchanged provider first failed compilation with
method does not override or implement a method from a supertype.After adding the memory-context parameter:
JAVA_HOME=$(/usr/libexec/java_home -v 25) mvn -B -ntp -nsu \ -Dmaven.repo.local=/Users/kurdyukov-kir/IdeaProjects/ydb-upstream-work/m2 \ -Dtrino.version=484-SNAPSHOT -f ydb-trino-adapter/pom.xml \ -Dtest=TestYdbExpressionRewrites,TestYdbColumnMappings,TestYdbJoinMappings,TestYdbMergeSink,TestYdbWriteMetadata,TestYdbPlugin \ verify24 passed; 0 failures, errors or skips. All production and test sources
compile; the actual production connector factory bootstraps and shuts down.
A full
testrun with the same snapshot override and documented Colimavariables reports 28 entries: 24 passed, 4 integration-class setup failures,
0 errors/skips. Each setup fails with
Ydb helper is not availablebecausethe existing Colima Docker socket is unavailable. No integration test completed.
Docker/Colima was not restarted or repaired.
docker-compose -f ydb-trino-adapter/examples/docker-compose.yml config --quietand
git diff --checkpass. The pre-existing obsolete Composeversionwarningremains. Java/YAML language servers are unavailable; compiler and Compose
validation were used.
These checks are not release-484 or real-YDB integration validation.
The prior 483 CI totals from #270 are not reused as proof of this upgrade.
Independent review
Independent code review of exact head
d059566audited the six-file deltaand the snapshot API contract and found no code/docs defects.
Recommendation: APPROVE for draft preparation only. This does not remove
the release-publication and real-YDB CI merge gates above.