Skip to content

Prepare Trino 484 adapter upgrade - #271

Draft
KirillKurdyukov wants to merge 1 commit into
mainfrom
update/trino-484
Draft

KirillKurdyukov wants to merge 1 commit into
mainfrom
update/trino-484

Conversation

@KirillKurdyukov

@KirillKurdyukov KirillKurdyukov commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Separate version upgrade after #270, based on canonical main
94955bb79c10fc9469cab2d13a422a8c0fa93a4f.

  • Target Trino 484 consistently in the Maven property and Compose example.
  • Adapt YdbPageSinkProvider.createMergeSink to the new trailing
    MemoryContext argument.
  • Preserve the existing legacy equality-JOIN path, capabilities, native type
    handling and non-transactional MERGE contract. No prototype engine changes
    or expression-JOIN parser are included.
  • Distinguish historical 483 results from preliminary snapshot validation.

Why this is a draft

As of 2026-10-01, both
Maven Central
and Trino releases still
publish 483 as the latest release. The default POM deliberately targets the
future 484 release, not a moving snapshot.

Release dependency resolution and normal release CI are therefore blocked.
This PR must remain draft until 484 artifacts are published and the complete
connector CI passes without a version override. No tests or CI checks are
disabled to hide this condition.

The actual CI run
for head d059566d06dfc551d81ebc9cb9ed9effbe55a99d confirms this blocker:
dependency:go-offline fails with
Could not find artifact io.trino:trino-base-jdbc:jar:484 in central.
The test step is not reached; this is not a passing CI run.

Preliminary validation

Java: Temurin 25.0.2. API reference: upstream
8d58343762f56a7d0f13b799f5521ddca6fbcfff, 484-SNAPSHOT.
Checks use locally built snapshot dependencies in a separate Maven repository.

The unchanged provider first failed compilation with
method does not override or implement a method from a supertype.
After adding the memory-context parameter:

JAVA_HOME=$(/usr/libexec/java_home -v 25) mvn -B -ntp -nsu \
  -Dmaven.repo.local=/Users/kurdyukov-kir/IdeaProjects/ydb-upstream-work/m2 \
  -Dtrino.version=484-SNAPSHOT -f ydb-trino-adapter/pom.xml \
  -Dtest=TestYdbExpressionRewrites,TestYdbColumnMappings,TestYdbJoinMappings,TestYdbMergeSink,TestYdbWriteMetadata,TestYdbPlugin \
  verify

24 passed; 0 failures, errors or skips. All production and test sources
compile; the actual production connector factory bootstraps and shuts down.

A full test run with the same snapshot override and documented Colima
variables reports 28 entries: 24 passed, 4 integration-class setup failures,
0 errors/skips
. Each setup fails with Ydb helper is not available because
the existing Colima Docker socket is unavailable. No integration test completed.
Docker/Colima was not restarted or repaired.

docker-compose -f ydb-trino-adapter/examples/docker-compose.yml config --quiet
and git diff --check pass. The pre-existing obsolete Compose version warning
remains. Java/YAML language servers are unavailable; compiler and Compose
validation were used.

These checks are not release-484 or real-YDB integration validation.
The prior 483 CI totals from #270 are not reused as proof of this upgrade.

Independent review

Independent code review of exact head d059566 audited the six-file delta
and the snapshot API contract and found no code/docs defects.
Recommendation: APPROVE for draft preparation only. This does not remove
the release-publication and real-YDB CI merge gates above.

Target release 484 and adapt the merge-sink provider memory context.
Keep the existing JOIN path and connector behavior declarations.

Release artifacts are not published yet. Local 484-SNAPSHOT validation
passes 24 unit/API tests; integration setup is blocked by missing Docker.
Document these limits and keep the upgrade as a draft until release CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant