fix(prover): emit missing marker on continuation verify paths#855
Open
Oppen wants to merge 1 commit into
Open
Conversation
…on verify paths verify_epoch and verify_global call multi_verify_views directly, without the marker prover/lib.rs's monolithic verify_proof_parts emits before its own multi_verify_views call. The recursion-block profile test buckets cycles by the latest marker observed, so on the continuation path "multi_verify setup (transcript replay phase A/B, per-table fork)" cycles were silently folded into whichever bucket was already active (airs_and_bus_balance for the first epoch, step4:openings carried over for later epochs), reporting the step at a flat 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify_epoch's per-epoch verify andverify_global(continuation.rs) callVerifier::multi_verify_viewsdirectly, without theSTEP_AIRS_AND_BUS_BALANCE_DONEmarker thatprover/lib.rs's monolithicverify_proof_partsemits before its ownmulti_verify_viewscall.test_recursion_profile_blowup4_block) buckets cycles by the latest marker observed, so on the continuation path the "multi_verify setup (transcript replay phase A/B, per-table fork)" step reported a flat 0% — its real cost was silently folded into whichever bucket was already active (airs_and_bus_balance for the first epoch, step4:openings carried over for later epochs/the global proof).Test plan
cargo check -p lambda-vm-prover --libmake test-profile-recursion-block— step 2 now reports 17,041,080 cycles (1.16%) instead of 0