perf: build PAGE trace from dense memory store#858
Open
ColoCarletti wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
/bench 5 |
Collaborator
Author
|
/bench-gpu |
GPU Benchmark (ABBA) —
|
Benchmark — ethrex 20 transfers (median of 3)Table parallelism: auto (cores / 3)
Commit: 44bcbf2 · Baseline: cached · Runner: self-hosted bench |
Collaborator
Author
|
/bench 10 |
ColoCarletti
force-pushed
the
perf-page-dense-gen
branch
from
July 24, 2026 18:49
086761e to
82a3d7a
Compare
jotabulacios
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Generate the PAGE trace tables by reading each cell's final
(value, timestamp)straight from the dense per-page memory store, instead of first building a sparseFinalStateMapand doing one (mostly-miss) lookup per page offset.Why
Those per-offset sparse-map lookups were the dominant cost of PAGE generation.
Reading the dense page slice directly is one indexed read per offset, no hashing.
Impact (ethrex 5-tx block, RTX 5090)
Produces the exact same PAGE trace —
prove+verifypass.Changes (3 files)
prover/src/paged_mem.rs: addPagedMem::page_data()(dense per-page slice).prover/src/tables/page.rs: addgenerate_page_trace_from_dense().prover/src/tables/trace_builder.rs:generate_page_tablesuses the dense path.