Repository navigation
feat: nanne v1 の最小一時チャットを実装 - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Issue #6 の最小v1を実装します。
exports方式)v1で意図的にやらないこと
検証結果
GitHub Actions CIで以下を確認済みです。
npm install: successnpm audit --omit=dev --audit-level=high: success(production dependency 0 vulnerabilities)node --test test/core.test.js: 3/3 passwrangler deploy --dry-run: successenv.ROOMS (Room)をWranglerが認識/r/<room-id>のSPA表示既知の開発依存警告
npm installの通常のaudit表示では high severity 3件が報告されます。詳細確認の結果、nanneの実行時依存ではなく、最新wrangler@4.130.0の開発ツール依存チェーンwrangler -> miniflare -> sharpに由来するものです。npm audit fix --forceは古いWranglerへの変更を提案するため採用していません。本番依存についてはCIでnpm audit --omit=dev --audit-level=highをfail条件として常設します。上流のWrangler/Miniflare更新時に再確認します。マージ前に残る確認
機能のコアはローカルWorker統合テストまで自動確認済みです。以下は実ブラウザでの見た目・操作感として未確認です。
画面・操作感は山田さん自身の確認が成果の核になるため、ここはマージ前の手動確認として残します。
Closes #6