Skip to content

do not use style-tags to prevent csp of unsafe-inline #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prauscher wants to merge 3 commits into
base: master
Choose a base branch
from
Open

do not use style-tags to prevent csp of unsafe-inline #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d485c2c
do not use style-tags to prevent csp of unsafe-inline
prauscher Jun 12, 2026
5c4cb69
add support for django-included csp which replaced django-csp
prauscher Jun 12, 2026
cdf739e
use django-csp nonce if provided, default to djangos built-in nonce
prauscher Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion session_security/static/session_security/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@
text-align: center;
}

.session_security {
.session_security_hidden {
display: none;
}
4 changes: 2 additions & 2 deletions session_security/templates/session_security/all.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
{# Bootstrap a SessionSecurity instance as the sessionSecurity global variable #}
{% with redirect_to_logout_flag=request|redirect_to_logout %}
{% localize off %}
<script type="text/javascript"{% if request.csp_nonce %} nonce="{{ request.csp_nonce }}"{% endif %}>
<script type="text/javascript" nonce="{% if request.csp_nonce %}{{ request.csp_nonce }}{% else %}{{ csp_nonce }}{% endif %}">
var sessionSecurity = new yourlabs.SessionSecurity({
pingUrl: '{% url 'session_security_ping' %}',
warnAfter: {{ request|warn_after|unlocalize }},
Expand All @@ -40,7 +40,7 @@
{# Hidden POST form for logout — required by Django 5.x (LogoutView no longer accepts GET) #}
{% with redirect_to_logout=request|redirect_to_logout %}
{% if redirect_to_logout %}
<form id="session_security_logout_form" action="{% url 'logout' %}" method="post" style="display:none">
<form id="session_security_logout_form" action="{% url 'logout' %}" method="post" class="session_security_hidden">
{% csrf_token %}
</form>
{% endif %}
Expand Down
2 changes: 1 addition & 1 deletion session_security/templates/session_security/dialog.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{% load i18n %}

<div id="session_security_warning" class="session_security" aria-hidden="true" role="dialog">
<div id="session_security_warning" class="session_security_hidden" aria-hidden="true" role="dialog">
<div class="session_security_overlay"></div>
<div class="session_security_modal" role="document" tabindex="-1">
<h3>{% trans 'Your session is about to expire' %}: <span id="session_security_counter"></span> {% trans 'seconds' %}</h3>
Expand Down
Loading