Repository navigation
Drop what nobody reads of user_preference - #905
Merged
Merged
Conversation
- UserWord.as_dictionary no longer sends user_preference: the web never read it (bookmarks carry no user_preference, so prioritizeBookmarksToStudy always returned early; web#1356 removes it). - The is_fit_for_study / not_fit_for_study endpoints go: their only caller was that function, past its early return, and both were broken (they set a non-column on Bookmark; not_fit_for_study passed a bookmark as a user word). - Looking a word up again no longer erodes "declared known" (-6 -> -4 ...): whether a word is known is the word-knowledge model's call. Before #903 it raised on the TEXT value, which is why prod has no -4 or -2 rows. First of the user_preference -> study_choice / unfit_reason PRs (docs/future-work/llm-tasks-roadmap.md, 0b). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
ArchLens - No architecturally relevant changes to the existing views |
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of roadmap 0b (
user_preference→study_choice/unfit_reason). Removals only, no schema change.UserWord.as_dictionarystops sendinguser_preference. The web never read it. Bookmarks don't carry the field, soprioritizeBookmarksToStudyalways returned early (web#1356 removes it), andWord.jsreads it only in a commented-out block. Installed app binaries run the same code, so they aren't affected./is_fit_for_studyand/not_fit_for_studyare removed. Their only caller was that function, after its early return. Both were broken anyway: they setfit_for_studyon aBookmark, which isn't a column there, andnot_fit_for_studypassed a bookmark toclear_user_word_schedule.Bookmark.find_or_create). Whether a word is still known is for the word-knowledge model to decide. Before user_preference read as text: two missed conversions; recompute fit after a validator fix #903 this code raised on the TEXT value, which is why prod has no −4 or −2 rows.is_declared_knowngoes too.Merge after web#1356.
Tests: the full core and API suites pass (1280 passed). One test of the wear-off is removed along with the code.
🤖 Generated with Claude Code