Repository navigation
Correct 23 past validator fixes, one learner's bookmark at a time - #911
Merged
Merged
Conversation
…er's bookmark at a time
The fixed meaning stays as it is for everyone else ('côté = kant' is right,
just not in 'De son côté'); only the bookmark in the fix's sentence moves to
the hand-checked card, placed on its words, and the move is logged. 23
corrections from the 25 Oct re-check of the top 300 fixes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
ArchLens detected architectural changes in the following views: |
…entences only find_or_create commits, so the per-bookmark savepoint protected nothing: the tool now checks the fix, the card and the placement first, then moves. A missing or non-FIX log and a card equal to the fixed meaning are skipped. Progress goes along when the word's other bookmarks are only generated examples. Every learner's own bookmark in the sentence is corrected (the pair is wrong there whoever has it). Cards in dictionary case. The dry run counts what would move. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the past validator fixes that the 25 Oct re-check (
regression/recheck/translation_validator--2026-10-25--top300.csv) found wrong, read by hand: 23 corrections inregression/recheck/translation_validator--2026-10-25--corrections.yaml.Only the learner's bookmark moves. A fix is wrong in one sentence, not in general: côté = kant is a fine meaning that 58 learners study; it was wrong only for the bookmark in "De son côté, …". So
correct_past_fix.movemoves that bookmark to the card (De son côté = van zijn kant) as a validator FIX would, but does not mark the fixed meaning INVALID. It also places the bookmark on the new words (the validator's own FIX path doesn't update the position when a word grows), carries the learner's progress over only when that sentence was all there was to the word, and logs the move invalidation_log("Re-check of past fixes, 25 Oct 2026: …").Generated-example bookmarks are left out (roadmap item 1); so is
continuer(log 19809) for that reason.tools/correct_rechecked_fixes.py <corrections.yaml>prints what would move;--applywrites. Everything that can fail (the log is a FIX, the card differs from the fixed meaning, its words are in the sentence) is checked before anything is written, sincefind_or_createcommits. Every learner's own bookmark in the sentence is corrected: the pair is wrong there whoever has it (in prod each of the 23 has one).Tests:
test_correct_rechecked_fixes.py.🤖 Generated with Claude Code