Bugfix/list key reuse - #84
Merged
Merged
Conversation
…e/remove List.set()/deriveList reused a keyConfig'd item's key across a content change at a shared index instead of retiring it, so a key could silently end up pointing at unrelated content. createCollection's applyChanges() had a related but separate issue: change/remove entries it could not resolve to a key without a content-based keyConfig were silently dropped instead of surfacing an error. diffPositional() now mints a fresh key on content mismatch when a keyConfig is given (matching splice()'s existing semantics), while the no-keyConfig positional case is unchanged. createCollection now throws UnresolvableKeyError for a change/remove entry it cannot resolve, instead of silently no-oping. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Pin was stuck at 1.4.1 while latest published is 1.5.1, adding three minor releases of accumulated drift to every measured ratio. The list-key-reuse fix on this branch only touches list.ts/collection.ts and cannot affect signalCreation, confirming the CI failure was drift, not a real regression.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.