Repository navigation
fix: claim / key when opening search - #240
Merged
squidfunk merged 1 commit intoSep 25, 2026
Merged
Conversation
Signed-off-by: John Carmack <johncarmack@me.com>
Member
|
Thanks for the PR and quick fix! I'm astonished this is the first time it is reported – not a Firefox user myself 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/shortcut opens search but doesn't claim the key. Firefox reads an unclaimed/as its Quick Find shortcut, so the find bar opens on top of the search dialog and takes focus from the query. You have to click back into the search field before you can type.Claiming the key once search is open keeps Firefox out of it. Material for MkDocs claimed
/the same way.Related issue
None, it's a small self-contained fix. Found while adding arrow-key paging to the MapLibre Martin docs (maplibre/martin#3385), which works around it from a page script for now.
Validation
npm run build. The unmodified tree rebuildsdistbyte for byte, so thedistdiff is only this change./still opens search with the query focused, the/keydown now arrives default-prevented (it didn't before), and a/typed inside the query still lands in the query.Checklist
Signed-off-bytrailer, accepting the DCO