Skip to content

Remove Aqara Pet Feeder "legacy" quirks from ZHA - #883

Draft
iamjoshk wants to merge 8 commits into
zigpy:devfrom
iamjoshk:iamjoshk-aqarapetfeeder
Draft

Remove Aqara Pet Feeder "legacy" quirks from ZHA#883
iamjoshk wants to merge 8 commits into
zigpy:devfrom
iamjoshk:iamjoshk-aqarapetfeeder

Conversation

@iamjoshk

@iamjoshk iamjoshk commented Sep 1, 2026

Copy link
Copy Markdown

Fixes #705
Dependent on PR for Aqara pet feeder quirk v2: updated PR for v2 migration: zigpy/zha-device-handlers#5296

This PR removes the "legacy" quirks from ZHA for the Aqara Pet Feeder.

  • Binary Sensor AqaraPetFeederErrorDetected class
  • Button AqaraPetFeederFeedButton class
  • Number AqaraPetFeederServingSize and AqaraPetFeederPortionWeight classes
  • Select AqaraFeedingMode and AqaraPetFeederMode classes
  • Sensor AqaraFeedingSource, AqaraPetFeederLastFeedingSource, AqaraPetFeederLastFeedingSize, and AqaraPetFeederPortionsDispensed classes
  • Switch AqaraPetFeederLEDIndicator and AqaraPetFeederChildLock classes
  • Virtual AqaraFeederInit class

Also removes the now unused import for UnitOfMass in number init and sensor init.

Remove AqaraPetFeederErrorDetected
Remove AqaraPetFeederFeedButton
Remove AqaraPetFeederPortionWeight and AqaraPetFeederServingSize
Remove AqaraFeedingSource, AqaraPetFeederWeightDispensed, AqaraPetFeederPortionsDispensed, AqaraPetFeederLastFeedingSize, and AqaraPetFeederLastFeedingSource
Remove AqaraPetFeederChildLock and AqaraPetFeederLEDIndicator
Remove AqaraPetFeederMode and AqaraFeedingMode
Remove AqaraFeederInit
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (7ea7e81) to head (814746e).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #883      +/-   ##
==========================================
- Coverage   97.19%   97.16%   -0.03%     
==========================================
  Files          57       57              
  Lines       10543    10440     -103     
==========================================
- Hits        10247    10144     -103     
  Misses        296      296              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new enum member to AqaraFeedingSource

1 participant