fix: release SuperKMeans sample buffer after rotation - #1832
Merged
Merged
Conversation
Signed-off-by: marcelo-cjl <marcelo.chen@zilliz.com>
marcelo-cjl
force-pushed
the
codex/release-superkmeans-sample-buffer
branch
from
September 16, 2026 03:59
91472ff to
00f7668
Compare
|
@marcelo-cjl 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
This was referenced Sep 16, 2026
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: foxspy, marcelo-cjl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issue: #1833
X_tildeMemory result
One build run on Cohere 1M x 768 FP32 with SCANN (
nlist=1024,sub_dim=2,with_raw_data=false, 16 threads):The sampled buffer is 768 MiB. The full-build average reduction is smaller because that buffer remains necessary during sampling and rotation.
Test plan
make WITH_UT=True BUILD_DIR=<workspace>/build/main/utknowhere_tests '[superkmeans],Test SuperKMeans*'(3 test cases, 44 assertions passed)git diff --checkRepository-wide pre-commit was also run. Its basic checks passed; clang-format reported existing formatting differences in unrelated files. This vendored path is excluded by that hook.
Closes #1833