Conversation
Signed-off-by: ChenLiqing <23721160+CLiqing@users.noreply.github.com>
Signed-off-by: ChenLiqing <23721160+CLiqing@users.noreply.github.com>
Signed-off-by: ChenLiqing <23721160+CLiqing@users.noreply.github.com>
Signed-off-by: ChenLiqing <23721160+CLiqing@users.noreply.github.com>
…urces Signed-off-by: ChenLiqing <23721160+CLiqing@users.noreply.github.com>
Signed-off-by: ChenLiqing <23721160+CLiqing@users.noreply.github.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CLiqing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@CLiqing 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
…itches Signed-off-by: ChenLiqing <23721160+CLiqing@users.noreply.github.com>
Signed-off-by: ChenLiqing <23721160+CLiqing@users.noreply.github.com>
…decs Signed-off-by: ChenLiqing <23721160+CLiqing@users.noreply.github.com>
…fore writes Signed-off-by: ChenLiqing <23721160+CLiqing@users.noreply.github.com>
Collaborator
|
@CLiqing is the PR ready to be reviewed? |
…ults Signed-off-by: ChenLiqing <23721160+CLiqing@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add RaBitQ as an optional in-memory navigation codec for DiskANN, reusing the Faiss RaBitQ implementation already integrated by #1814. PQ remains the default. The disk graph, traversal, candidate queues, and SSD I/O paths remain shared.
issue: #1747.
Functionality
navigation_codec="RABITQ"onDISKANN, or use theDISKANN_RABITQalias. RaBitQ supports FP32 input with L2, IP, and COSINE metrics.rbq_bits_querysupports 0 to 8 (default 4).DISKANN, without repeating the build-time codec or bits. Explicit codec/alias constraints must match; ambiguous, missing, or corrupt selected models fail rather than silently falling back. SSD PQ files are independent of navigation discovery.Shared correctness fixes
Scope
RaBitQ iterator/range-search and embedding-list support are not included. AiSAQ continues to use PQ navigation. This does not change HNSW RaBitQ kernels, add TQ/IVF support, or relax the existing PQ chunk build limit.
Validation
Latest resource-estimation fix at
4155d20e:Earlier local x86-64 validation at
48768d18:36f1cd09, with identical recall, IDs, and distance hashes. High-dimensional RaBitQ QPS changes ranged from -0.39% to +1.18%; a longer GIST PQ check reproduced 2.35% lower QPS and 3.74% higher CPU/query. This is not a blanket no-regression guarantee.ARM/Cardinal builds and upstream CI have not been validated locally. All commits include DCO sign-offs. Experiment reports and datasets are not part of this PR.