Skip to content

build: upgrade milvus-common to 45fca32 - #1859

Merged
sre-ci-robot merged 2 commits into
zilliztech:mainfrom
foxspy:build/upgrade-milvus-common-45fca32
Sep 29, 2026
Merged

sre-ci-robot merged 2 commits into
zilliztech:mainfrom
foxspy:build/upgrade-milvus-common-45fca32

Conversation

@foxspy

@foxspy foxspy commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Upgrade milvus-common from 1.0.0-b589c5a to the published 1.0.0-45fca32 recipe, pinned to revision ac7e38699c9dcc9a83d5be95e8227900.

The updated common public headers expose Folly. Keep Python wheel builds compatible by adding the Conan include paths for Folly, double-conversion, and fmt, and compiling the extension with C++20. This resolves the missing folly/futures/Future.h error and the C++20 requirement encountered during wheel builds.

This upgrade includes the best-effort AIO context replacement support merged in zilliztech/milvus-common#137. The recipe was published through milvus-io/conanfiles#197.

Validation:

  • Conan dependency installation and the CPU/DiskANN library and knowhere_tests build passed with GCC 12 / C++20 / Release.
  • Tracer, configuration, thread-pool, timing, disk-load, and brute-force regression tests passed: 18 cases / 267,800 assertions.
  • Runtime library resolution was checked against the updated common package.
  • On Linux x86_64 with Python 3.10, python/build_portable_wheel.sh passed compilation, linking, auditwheel repair, and portability checks.
  • Installed the resulting wheel and verified importing knowhere; tests/python/test_index_with_random.py passed all 5 cases.
  • pre-commit and git diff --check passed for the changed files.

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
@sre-ci-robot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify

mergify Bot commented Sep 29, 2026

Copy link
Copy Markdown

@foxspy e2e jenkins job failed, comment /run-e2e can trigger the job again.

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
@CLiqing

CLiqing commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

/lgtm

@mergify mergify Bot added the ci-passed label Sep 29, 2026
@sre-ci-robot
sre-ci-robot merged commit 9ab6d76 into zilliztech:main Sep 29, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants