build: upgrade milvus-common to 45fca32 - #1859
Merged
sre-ci-robot merged 2 commits intoSep 29, 2026
Merged
Conversation
Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@foxspy e2e jenkins job failed, comment |
Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
Collaborator
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade milvus-common from
1.0.0-b589c5ato the published1.0.0-45fca32recipe, pinned to revisionac7e38699c9dcc9a83d5be95e8227900.The updated common public headers expose Folly. Keep Python wheel builds compatible by adding the Conan include paths for Folly, double-conversion, and fmt, and compiling the extension with C++20. This resolves the missing
folly/futures/Future.herror and the C++20 requirement encountered during wheel builds.This upgrade includes the best-effort AIO context replacement support merged in zilliztech/milvus-common#137. The recipe was published through milvus-io/conanfiles#197.
Validation:
knowhere_testsbuild passed with GCC 12 / C++20 / Release.python/build_portable_wheel.shpassed compilation, linking, auditwheel repair, and portability checks.knowhere;tests/python/test_index_with_random.pypassed all 5 cases.pre-commitandgit diff --checkpassed for the changed files.