Fold Discover/Make into the mobile drawer, fix Wonder-spark touch targets - #33
Conversation
…gets Found via a real phone-viewport click-through: - The mobile top bar showed both the left-side Discover dropdown/Make link AND the hamburger drawer at once, duplicating navigation and cluttering the header — the drawer's mobileLinks already listed every Discover destination, so hiding .controls-left at the same breakpoint .nav-desktop-right already uses loses no functionality. Added the one missing link (Make) to the drawer to make it the complete single menu. - Studio's Wonder-spark buttons hide their hint text below 640px but didn't compensate the now-single-line button's height, dropping it under the 44px touch-target floor (~35px). Added min-height: 44px. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EaaR33pESTKNNDWfm9y9Nm
|
Warning Review limit reachedNext included review available in 55 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe mobile layout now hides the left controls, adds ChangesMobile UI updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The mobile navigation and touch-target updates are ready to merge; no material user-facing regression is currently indicated. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f358803e9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Hiding .controls-left with display:none removes it from CSS Grid entirely, so with it and .nav-desktop-right both hidden at mobile widths, auto-placement slid the logo into column 1 and the hamburger into column 2 instead of the intended centered/right layout. Assigned explicit grid-column values so placement no longer depends on which siblings are visible, and switched the mobile grid back to symmetric 1fr flanks (matching desktop) instead of auto 1fr auto — an empty auto column collapses to 0 width while the hamburger's auto column keeps its real width, which still pulled the logo left of true center even with explicit columns assigned. Verified with real boundingBox() measurements: logo-to-bar-center offset is now 0px at both 390px (drawer closed and open) and 1280px, versus 20px off-center before this fix. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EaaR33pESTKNNDWfm9y9Nm
Summary
Found via a real phone-viewport (390×844) click-through in a browser, after #31/#32 merged — requested directly by the user after seeing a screenshot of the drawer open on their own phone.
.controls-leftat the samemax-width: 640pxbreakpoint.nav-desktop-rightalready uses, and added the one link the drawer was missing (Make) so it's a complete single menu with no functionality lost.min-height: 44px.Test plan
npx tsc --noEmit,npm run lint,npm test(470/470) — all clean.controls-leftconfirmed hidden, "Make" confirmed present and visible inside the drawer.controls-leftand the Discover dropdown confirmed still visible/functional — desktop nav unaffected.wonder-sparkbounding-box height measured at 390px after the fix: 63px (was ~35px)🤖 Generated with Claude Code
https://claude.ai/code/session_01EaaR33pESTKNNDWfm9y9Nm
Generated by Claude Code
Summary by CodeRabbit
New Features
Bug Fixes