Skip to content

Fold Discover/Make into the mobile drawer, fix Wonder-spark touch targets - #33

Merged
zowskyy merged 2 commits into
mainfrom
claude/adoring-brahmagupta-5n6xwe
Sep 13, 2026
Merged

zowskyy merged 2 commits into
mainfrom
claude/adoring-brahmagupta-5n6xwe

Conversation

@zowskyy

@zowskyy zowskyy commented Sep 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

Found via a real phone-viewport (390×844) click-through in a browser, after #31/#32 merged — requested directly by the user after seeing a screenshot of the drawer open on their own phone.

  • The mobile top bar showed both the left-side Discover dropdown + Make link and the hamburger drawer at the same time — the drawer already lists every Discover destination (Explore/Wander/Feed/Vibe/Rings), so this just duplicated navigation and cluttered the header. Hid .controls-left at the same max-width: 640px breakpoint .nav-desktop-right already uses, and added the one link the drawer was missing (Make) so it's a complete single menu with no functionality lost.
  • While reviewing Studio screenshots, found Wonder-spark buttons (the "Surprise me / Add a shrine / …" chips) hide their hint text below 640px but didn't compensate the resulting single-line button's height — it dropped to ~35px, under the 44px touch-target floor established in Make Nav, Settings, Rings, and Wander genuinely touch-first #31. Added min-height: 44px.

Test plan

  • npx tsc --noEmit, npm run lint, npm test (470/470) — all clean
  • Real Playwright check at 390px: .controls-left confirmed hidden, "Make" confirmed present and visible inside the drawer
  • Real Playwright check at 1280px: .controls-left and the Discover dropdown confirmed still visible/functional — desktop nav unaffected
  • .wonder-spark bounding-box height measured at 390px after the fix: 63px (was ~35px)
  • Full CI run (pending)

🤖 Generated with Claude Code

https://claude.ai/code/session_01EaaR33pESTKNNDWfm9y9Nm


Generated by Claude Code

Summary by CodeRabbit

  • New Features

    • Added a mobile navigation link for creating content.
    • Improved the mobile prompt layout with a centered design and a minimum 44px touch target.
  • Bug Fixes

    • Simplified mobile navigation by hiding duplicate left-side controls, making the navigation drawer the single menu entry point.

…gets

Found via a real phone-viewport click-through:

- The mobile top bar showed both the left-side Discover dropdown/Make
  link AND the hamburger drawer at once, duplicating navigation and
  cluttering the header — the drawer's mobileLinks already listed every
  Discover destination, so hiding .controls-left at the same breakpoint
  .nav-desktop-right already uses loses no functionality. Added the one
  missing link (Make) to the drawer to make it the complete single menu.
- Studio's Wonder-spark buttons hide their hint text below 640px but
  didn't compensate the now-single-line button's height, dropping it
  under the 44px touch-target floor (~35px). Added min-height: 44px.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EaaR33pESTKNNDWfm9y9Nm
@coderabbitai

coderabbitai Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Warning

Review limit reached

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 68d1a021-bd1a-4229-8f82-07cd67bea8c2

📥 Commits

Reviewing files that changed from the base of the PR and between f358803 and 53266ec.

📒 Files selected for processing (1)
  • app/src/app/nav.css

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: b767c891-fbba-4425-b230-bf1a6054a7a5

📥 Commits

Reviewing files that changed from the base of the PR and between ef43ee5 and f358803.

📒 Files selected for processing (3)
  • app/src/app/nav.css
  • app/src/app/platform.css
  • app/src/components/SiteNav.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The mobile layout now hides the left controls, adds /make to the mobile drawer, and preserves a 44px minimum height for the remaining spark line.

Changes

Mobile UI updates

Layer / File(s) Summary
Mobile navigation behavior
app/src/app/nav.css, app/src/components/SiteNav.tsx
The mobile layout hides the left controls. The mobile drawer includes a /make link.
Spark touch-target sizing
app/src/app/platform.css
The mobile .wonder-spark element uses a 44px minimum height and centered content.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: claude

Merge Risk: ⚪ Minimal · up to f3588

The mobile navigation and touch-target updates are ready to merge; no material user-facing regression is currently indicated.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: consolidating Discover and Make in the mobile drawer and fixing Wonder-spark touch targets.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/adoring-brahmagupta-5n6xwe

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zowskyy
zowskyy marked this pull request as ready for review September 13, 2026 00:47

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f358803e9b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/src/app/nav.css
Hiding .controls-left with display:none removes it from CSS Grid
entirely, so with it and .nav-desktop-right both hidden at mobile
widths, auto-placement slid the logo into column 1 and the hamburger
into column 2 instead of the intended centered/right layout. Assigned
explicit grid-column values so placement no longer depends on which
siblings are visible, and switched the mobile grid back to symmetric
1fr flanks (matching desktop) instead of auto 1fr auto — an empty auto
column collapses to 0 width while the hamburger's auto column keeps
its real width, which still pulled the logo left of true center even
with explicit columns assigned.

Verified with real boundingBox() measurements: logo-to-bar-center
offset is now 0px at both 390px (drawer closed and open) and 1280px,
versus 20px off-center before this fix.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EaaR33pESTKNNDWfm9y9Nm
@zowskyy
zowskyy merged commit 95de221 into main Sep 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants