Repository navigation
Avoid false password warnings on JavaScript credential lookups - #6
Merged
Merged
Conversation
zztimur
marked this pull request as ready for review
September 7, 2026 01:02
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A JavaScript password variable initialized from CLI flags or environment variables currently triggers a bundled-password warning. Recognize complete lookup-only declarations in .js/.mjs/.cjs files while retaining warnings for hardcoded values, literal fallbacks, later assignments, and text configuration files.
The exception requires a complete single-line declaration ending in a semicolon. Earlier template delimiters leave the context uncertain, so those files retain the warning even when a preceding template appears closed. This deliberately conservative fix does not change output redaction, public finding codes, severity, CLI arguments, or the report schema. Credential/network dependency reporting remains separate in #5.
Validation:
Fixes #4.