Add Volcengine smoke and full Provider replay - #89
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 898cb0599e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if replay_scope == "smoke": | ||
| if provider_report.get("cases") != 1: | ||
| raise SystemExit("Smoke replay must execute exactly one case.") |
There was a problem hiding this comment.
Reject smoke replays with unparsable provider output
When Volcengine returns plain text or malformed JSON, parse_provider_answer() records a fallback candidate with a nonempty results[].parse_error, while run_provider_answer_replay() still reports status: completed and produces an answer_quality dictionary. This smoke branch checks only counts and scope, so that response passes the workflow even though the smoke is intended to establish JSON/schema compatibility before a full paid run; inspect the selected result's parse error and fail the smoke when it is nonempty.
Useful? React with 👍 / 👎.
Scope
Continue P0-E3 with a replay-only Volcengine Ark adapter and bounded smoke/full workflow modes. This measures compatibility before any production Provider expansion.
Changes
VolcengineArkReplayProvideras a subclass of the provenance-approved real-provider replay adapterhttps://ark.cn-beijing.volces.com/api/v3VOLCENGINE_API_KEYwithARK_API_KEYfallback and an exact Model ID / Endpoint ID--model-nameand--base-urlreplay argumentssmokemode that runs onlyclean_requests_sessionfull, which runs all 10 gold cases/api/plan/v3and Coding Plan/api/coding/v3in adapter code, tests and documentationBoundaries
Validation
Final head CI #1696 passed the complete repository gate: pytest, RAG K1, Ruff, packaging, detect-secrets, expanded mypy, frontend tests/build, 35/35 fixture+narrow browser journeys and 12/12 real-stack cases.
No real Volcengine request was made. After merge, the next operation is one manually dispatched Volcengine smoke using the exact Model/Endpoint ID. Only a green smoke may proceed to two full 10-case runs.