Repository navigation
fix(admin): open resource usage links outside of the dialog frame - #4342
Merged
Merged
Conversation
The picture overlay and the attachment dialog both render inside a Turbo Frame, so the links to the pages using a resource were loaded into that frame and showed a broken page edit screen inside the dialog. Targeting _top makes them navigate the whole page instead.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4342 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 362 362
Lines 9646 9646
=======================================
Hits 9489 9489
Misses 157 157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sascha-karnatz
approved these changes
Oct 13, 2026
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
The "used on these pages" list in the picture overlay and in the attachment dialog links to the page and element where a resource is used. Both dialogs render inside a Turbo Frame (
picture_overlayandalchemy_dialog_frame), so clicking one of those links loaded the page edit screen into the frame, which left a broken page inside the dialog. The links now target_top, so they navigate the whole page to the page editor.Checklist