Repository navigation
[8.4-stable] fix(admin): open resource usage links outside of the dialog frame - #4343
Merged
Merged
Conversation
The picture overlay and the attachment dialog both render inside a Turbo Frame, so the links to the pages using a resource were loaded into that frame and showed a broken page edit screen inside the dialog. Targeting _top makes them navigate the whole page instead. (cherry picked from commit 676e128)
3 tasks done
tvdeyen
approved these changes
Oct 14, 2026
tvdeyen
enabled auto-merge
October 14, 2026 07:04
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.4-stable #4343 +/- ##
===========================================
Coverage 98.37% 98.37%
===========================================
Files 362 362
Lines 9646 9646
===========================================
Hits 9489 9489
Misses 157 157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.4-stable:Questions ?
Please refer to the Backport tool documentation