fix(runtime): route interface calls to selected providers - #101
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a01770-9c07-702e-88aa-e05d2429c047 Co-authored-by: Upd4ting <upd4ting@gmail.com>
Member
Author
|
@greptile review |
…ntime # Conflicts: # src/core/module-manager.ts # src/core/module.ts
Co-authored-by: Upd4ting <upd4ting@gmail.com>
Co-authored-by: Upd4ting <upd4ting@gmail.com>
Member
Author
|
@greptile review |
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
importOverridesas metadata onlyproviderRoutesfrom fix(core): make interface package resolution deterministic #97's canonical interface package entries and stable proxy identitiesprovider/selectedconnection metadata that matches actual dispatchPublished dependency contract
This branch now uses the released npm package
@antelopejs/interface-core@^0.0.11(runtime protocol 3), backed by interface-core #10 / commit12cc970170e6188d70158b7e53de9815f15679e9.The temporary Git SHA, pnpm
patchedDependencies, workspace patch configuration, and patch file have been removed. The implementation uses only the public 0.0.11 contract:ModuleExecutionContext.owner, provider route context, provider callback context restoration, attachment leases, generation cleanup, and provider selection metadata.Integration with current main
The branch includes
origin/mainthrough #100 (c5675ea8998ec71a8a60b8ec2b00d2efaa57a45f) without rewritten history:Routing invariants
ModuleDestroyedruns in the destroyed generation's context; stale cleanup cannot detach a replacement with the same module/provider IDPackage-consumer proof
pnpm test:package-consumerbuilds and packs@antelopejs/core, installs that tarball into a fresh project, and verifies:@antelopejs/interface-core@^0.0.11This test is part of
pnpm test, so CI exercises the packed-consumer contract.Fresh verification
Node 22.19.0, pnpm 10.6.5:
pnpm install --frozen-lockfile— passpnpm lint— pass (three pre-existing warnings/info only)pnpm build— passpnpm test:unit— pass, including full integration and HMR suitespnpm test:coverage— pass; 94.52% lines/statements, 92.03% branches, 91.93% functionspnpm test:playground— all three phases passpnpm test:package-consumer— pass from a fresh tarball installgit diff --check— passNo merge or package publication is performed by this PR.
Greptile Summary
The PR adds deterministic, consumer-specific provider routing and generation-owned module execution contexts.
@antelopejs/interface-coreto the released protocol-3 implementation.Confidence Score: 5/5
The PR appears safe to merge because no blocking failure remains.
No blocking failure remains.
Important Files Changed
Sequence Diagram
sequenceDiagram participant MM as ModuleManager participant IR as InterfaceRegistry participant M as Consumer Module participant P as Interface Proxy participant Provider as Selected Provider MM->>MM: Collect all compatible providers MM->>MM: Select override or sorted default MM->>IR: Publish connections and selected metadata MM->>M: Set proxy identity to provider routes M->>M: Enter generation-owned context M->>P: Invoke interface function P->>Provider: Dispatch using consumer route Provider-->>M: Return result in provider contextReviews (2): Last reviewed commit: "fix(runtime): adopt published provider c..." | Re-trigger Greptile