fix: probe compiled RIMAPI DLL before Workshop - #70
Merged
Conversation
Restore run-metadata pins to the compiled fork checkout. Probe RIMAPI_DLL_PATH, then RIMAPI_FORK_PATH, then the sibling of the RLE git toplevel, and only then the Workshop overlay. Fork commit uses the same env plus git toplevel sibling so site-packages installs still record the pin. Co-authored-by: Jason <jkbennitt@users.noreply.github.com>
Identical marker files produced the same short hash, so the env-over-sibling assertion could not distinguish the two repos. Co-authored-by: Jason <jkbennitt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore run-metadata RIMAPI pins to the compiled fork checkout. Workshop is no longer treated as source of truth.
collect_metadata()now probes DLLs in this order (first existing file wins):$RIMAPI_DLL_PATH$RIMAPI_FORK_PATH/1.6/Assemblies/RIMAPI.dll../RIMAPI/1.6/Assemblies/RIMAPI.dllFork commit honors
$RIMAPI_FORK_PATH, then the sibling ofgit rev-parse --show-toplevel.Path(__file__).parents[3]is no longer the only fallback — that path is empty from site-packages /.venv. Missing fork still records"".AppSprout runs should set
RIMAPI_DLL_PATHandRIMAPI_FORK_PATHto the compiled checkout. Summaries recordrimapi_dll_path,rimapi_dll_sha256, andrimapi_fork_commit.Known pins (not re-hashed here): compiled
BFC9DD53…@b6c5003; Workshop73E659E8…is Flash drift.Docs
CLAUDE.md,README.md,CONTRIBUTING.md,.env.exampledocs/2026-09-07-rimapi-path-probe.md/workspace/drafts/2026-09-07-rimapi-path-probe.mdis not in this repo and will be written separatelyTests
Focused suite on this revision:
pytest tests/unit/test_metadata.py— 17 passed (probe order, compiled-over-workshop, fork-commit env/fallback/empty, site-packages skip, summary fields)ruff check src/rle/tracking/metadata.py tests/unit/test_metadata.py— cleanmypy src/rle/tracking/metadata.py— cleanPlan