Skip to content

Boost: Organize modern settings into collapsible sections - #52562

Merged
LiamSarsfield merged 5 commits into
trunkfrom
fm/boost-747-settings-sections
Sep 22, 2026
Merged

LiamSarsfield merged 5 commits into
trunkfrom
fm/boost-747-settings-sections

Conversation

@LiamSarsfield

@LiamSarsfield LiamSarsfield commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Fixes BOOST-747

Proposed changes

Modern Settings now has four collapsible sections: Cornerstone pages, Page loading, Code optimization, and Images. Headers include icons and descriptions; rules separate rows. Cornerstone starts collapsed, with the other sections open. Its summary appears in the header; its description, editor, and Prerender row appear once inside.

Reuse check

Reuse @wordpress/ui CollapsibleCard and @wordpress/icons, following Cornerstone and SEO Settings.

Related product discussion/links

See the issue referenced above.

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  1. Enable rsm_jetpack_ui_modernization_boost and open Boost → Settings. Check section order, default states, each toggle, and the nested Cornerstone editor.
  2. Repeat at 1280 and 782 pixels, including RTL, with SCRIPT_DEBUG false.
  3. Disable the filter and compare the legacy dashboard.

Production build, 436 Jest tests and eight tooltip browser tests, TypeScript, ESLint, and Stylelint pass.

All changed runtime code is modern-only; no shared translation strings changed. Legacy settings DOM is identical between merge-base and head builds (31,999 characters); legacy screenshots have zero differing pixels at both widths.

View Before After
Modern desktop Before After
Modern mobile Before After
Legacy desktop Before After
Legacy mobile Before After

RTL: 1280, 782. Cornerstone open at 1280.

Cornerstone open: 782, RTL 1280, RTL 782.

@LiamSarsfield
LiamSarsfield requested a review from a team as a code owner September 21, 2026 16:57
@LiamSarsfield
LiamSarsfield marked this pull request as draft September 21, 2026 16:58
@LiamSarsfield LiamSarsfield changed the title feat(boost): organize modern settings into collapsible sections Boost: Organize modern settings into collapsible sections Sep 21, 2026
@github-actions github-actions Bot added [Plugin] Boost A feature to speed up the site and improve performance. [Tests] Includes Tests E2E Tests labels Sep 21, 2026
@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions Bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Sep 21, 2026
@jp-launch-control

jp-launch-control Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/plugins/boost/app/assets/src/js/features/cornerstone-pages/cornerstone-pages-card.tsx 6/6 (100.00%) 0.00% 0 💚
projects/plugins/boost/app/assets/src/js/pages/settings/settings.tsx 5/5 (100.00%) 0.00% 0 💚

Full summary · PHP report · JS report

@LiamSarsfield
LiamSarsfield force-pushed the fm/boost-747-settings-sections branch from ac8b118 to e245b4e Compare September 21, 2026 18:19
@github-actions github-actions Bot added the Docs label Sep 21, 2026
@LiamSarsfield
LiamSarsfield marked this pull request as ready for review September 22, 2026 08:05
@LiamSarsfield
LiamSarsfield merged commit e92030e into trunk Sep 22, 2026
90 checks passed
@LiamSarsfield
LiamSarsfield deleted the fm/boost-747-settings-sections branch September 22, 2026 08:05
@github-actions github-actions Bot added [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs E2E Tests [Plugin] Boost A feature to speed up the site and improve performance. [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant