Repository navigation
fix(boost): show the Cornerstone pages description in the collapsed Settings header - #52624
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
…-group-description # Conflicts: # projects/plugins/boost/app/assets/src/js/pages/settings/settings.test.tsx
Proposed changes
Groupdescriptionslot as the other groups. The header button'saria-describedbynow points at it, and its accessible name stays "Cornerstone pages".Screenshots
Modern Settings, "Cornerstone pages" collapsed. Below the new line, the after image is the before image shifted down 32 px, pixel for pixel.
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
rsm_jetpack_ui_modernization_boostfilter and open Boost > Settings.pnpm test app/assets/src/js/pages/settingsinprojects/plugins/boost: the new test finds the collapsed header button by that description.