Skip to content

fix(boost): show the Cornerstone pages description in the collapsed Settings header - #52624

Merged
xavier-lc merged 2 commits into
trunkfrom
fm/boost-cornerstone-group-description
Sep 25, 2026
Merged

xavier-lc merged 2 commits into
trunkfrom
fm/boost-cornerstone-group-description

Conversation

@LiamSarsfield

@LiamSarsfield LiamSarsfield commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Proposed changes

  • On the modern Settings page, the collapsed "Cornerstone pages" group now shows its one-line description in the header ("Choose the pages that matter most on your site so Boost can give them its most targeted optimizations."), like the other groups. Before, it only showed after expanding.
  • The text goes through the same Group description slot as the other groups. The header button's aria-describedby now points at it, and its accessible name stays "Cornerstone pages".
  • It reuses the legacy dashboard's existing string, so it needs no new translation. The fuller explanation inside the body is unchanged.
  • The legacy dashboard is unaffected. Its rendered HTML is byte-identical before and after, and screenshots at 1280 and 782 px, LTR and RTL, match pixel for pixel.

Screenshots

Modern Settings, "Cornerstone pages" collapsed. Below the new line, the after image is the before image shifted down 32 px, pixel for pixel.

Before After
LTR, 1280 px before LTR after LTR
RTL, 782 px before RTL after RTL

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • Enable the modern dashboard with the rsm_jetpack_ui_modernization_boost filter and open Boost > Settings.
  • With "Cornerstone pages" collapsed, confirm the description shows under the title and page summary, in LTR and RTL at desktop and narrow widths.
  • Expand it and confirm the body still shows the fuller explanation.
  • With a screen reader, focus the header button and confirm it reads the name, then the description.
  • pnpm test app/assets/src/js/pages/settings in projects/plugins/boost: the new test finds the collapsed header button by that description.

@LiamSarsfield
LiamSarsfield requested a review from a team as a code owner September 22, 2026 13:24
@github-actions github-actions Bot added the [Plugin] Boost A feature to speed up the site and improve performance. label Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Sep 22, 2026
@LiamSarsfield
LiamSarsfield marked this pull request as draft September 22, 2026 13:28
@jp-launch-control

jp-launch-control Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

LiamSarsfield added a commit that referenced this pull request Sep 22, 2026
LiamSarsfield added a commit that referenced this pull request Sep 22, 2026
LiamSarsfield added a commit that referenced this pull request Sep 22, 2026
LiamSarsfield added a commit that referenced this pull request Sep 22, 2026
@xavier-lc
xavier-lc marked this pull request as ready for review September 25, 2026 12:19
…-group-description

# Conflicts:
#	projects/plugins/boost/app/assets/src/js/pages/settings/settings.test.tsx

@xavier-lc xavier-lc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier-lc xavier-lc added the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 25, 2026
@xavier-lc
xavier-lc merged commit 80cd42a into trunk Sep 25, 2026
95 checks passed
@xavier-lc
xavier-lc deleted the fm/boost-cornerstone-group-description branch September 25, 2026 13:44
@github-actions github-actions Bot removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Ready to Merge Go ahead, you can push that green button! [Status] In Progress labels Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Boost A feature to speed up the site and improve performance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants