Skip to content

refactor(boost): share modern settings well styles - #52608

Merged
LiamSarsfield merged 1 commit into
trunkfrom
fm/boost-746-shared-well-mixin
Sep 22, 2026
Merged

LiamSarsfield merged 1 commit into
trunkfrom
fm/boost-746-shared-well-mixin

Conversation

@LiamSarsfield

@LiamSarsfield LiamSarsfield commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Proposed changes

Share the modern Settings well background, border, radius, and padding through a Sass mixin. The Except panel, Critical CSS status, Image CDN controls, and LCP status retain their existing selectors and markup.

A mixin needs fewer call-site edits than a ModuleSubsection variant: each existing SCSS block includes it without changing React components. The Except panel passes null padding because its toggle and expanded content already own their padding.

Related product discussion/links

None.

Does this pull request change what data or activity we track or use?

No.

Testing instructions

Enable the modern Boost dashboard and Image CDN premium controls. Compare Settings at widths 1280 and 782 in LTR and RTL, with Except and image quality panels collapsed and expanded. Switch back to the legacy dashboard and repeat.

Both production builds passed. Both compiled sheets are byte-identical (SHA-256):

  • jetpack-boost.css: bad2513e68e526fa6fe15c5e4668b7ca8f55fcee8034ce6429b5b7e9881f748b
  • jetpack-boost.rtl.css: 83941619fded67e30ddf3716460f61ea9af822a92cb1288bfd539a4dd4f8b9fb

All 16 raw rendered HTML comparisons match, including all eight legacy cases. These establish no change to the rendered markup or styles.

Fourteen screenshot pairs match pixel-for-pixel. Two expanded modern RTL captures show capture noise: 30 pixels at width 1280 and 5 at width 782. Diff images are retained as diff-modern-1280-rtl-expanded.png and diff-modern-782-rtl-expanded.png in the validation evidence.

Six focused Jest suites (38 tests) and Stylelint passed. Boost e2e specs could not run in this checkout; the Docker browser pass supplies the rendering evidence.

@LiamSarsfield
LiamSarsfield requested a review from a team as a code owner September 22, 2026 08:42
@github-actions github-actions Bot added the [Plugin] Boost A feature to speed up the site and improve performance. label Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Sep 22, 2026
@LiamSarsfield
LiamSarsfield marked this pull request as draft September 22, 2026 08:44
@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@LiamSarsfield
LiamSarsfield marked this pull request as ready for review September 22, 2026 09:41
@LiamSarsfield
LiamSarsfield marked this pull request as draft September 22, 2026 09:50

@xavier-lc xavier-lc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LiamSarsfield
LiamSarsfield marked this pull request as ready for review September 22, 2026 11:49
@LiamSarsfield
LiamSarsfield merged commit 796412d into trunk Sep 22, 2026
95 checks passed
@LiamSarsfield
LiamSarsfield deleted the fm/boost-746-shared-well-mixin branch September 22, 2026 11:50
@github-actions github-actions Bot removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Boost A feature to speed up the site and improve performance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants