Repository navigation
refactor(boost): share modern settings well styles - #52608
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Proposed changes
Share the modern Settings well background, border, radius, and padding through a Sass mixin. The Except panel, Critical CSS status, Image CDN controls, and LCP status retain their existing selectors and markup.
A mixin needs fewer call-site edits than a ModuleSubsection variant: each existing SCSS block includes it without changing React components. The Except panel passes null padding because its toggle and expanded content already own their padding.
Related product discussion/links
None.
Does this pull request change what data or activity we track or use?
No.
Testing instructions
Enable the modern Boost dashboard and Image CDN premium controls. Compare Settings at widths 1280 and 782 in LTR and RTL, with Except and image quality panels collapsed and expanded. Switch back to the legacy dashboard and repeat.
Both production builds passed. Both compiled sheets are byte-identical (SHA-256):
jetpack-boost.css:bad2513e68e526fa6fe15c5e4668b7ca8f55fcee8034ce6429b5b7e9881f748bjetpack-boost.rtl.css:83941619fded67e30ddf3716460f61ea9af822a92cb1288bfd539a4dd4f8b9fbAll 16 raw rendered HTML comparisons match, including all eight legacy cases. These establish no change to the rendered markup or styles.
Fourteen screenshot pairs match pixel-for-pixel. Two expanded modern RTL captures show capture noise: 30 pixels at width 1280 and 5 at width 782. Diff images are retained as
diff-modern-1280-rtl-expanded.pnganddiff-modern-782-rtl-expanded.pngin the validation evidence.Six focused Jest suites (38 tests) and Stylelint passed. Boost e2e specs could not run in this checkout; the Docker browser pass supplies the rendering evidence.