Skip to content

refactor(boost): share modern settings well styles #52608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LiamSarsfield merged 1 commit into from
Sep 22, 2026
Merged

refactor(boost): share modern settings well styles #52608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions projects/plugins/boost/app/assets/src/css/main/mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,10 @@
max-inline-size: var(--wpds-dimension-surface-width-xl);
margin-inline: auto;
}

@mixin settings-well($padding: var(--wpds-dimension-padding-lg)) {
padding: $padding;
background: var(--wpds-color-background-surface-neutral);
border: var(--wpds-border-width-xs) solid var(--wpds-color-stroke-surface-neutral-weak);
border-radius: var(--wpds-border-radius-lg);
}
8 changes: 4 additions & 4 deletions ...ets/src/js/features/critical-css/critical-css-meta/modern-critical-css-status.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
@use "$css/main/mixins";

.well {
padding: var(--wpds-dimension-padding-lg);
border: var(--wpds-border-width-xs) solid var(--wpds-color-stroke-surface-neutral-weak);
border-radius: var(--wpds-border-radius-lg);
background: var(--wpds-color-background-surface-neutral);

@include mixins.settings-well();
}

.description {
Expand Down
9 changes: 5 additions & 4 deletions ...gins/boost/app/assets/src/js/features/image-cdn/image-cdn-liar/image-cdn-liar.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use "$css/main/mixins";

.wrapper {
margin-bottom: 10px;
}
Expand All @@ -23,10 +25,9 @@
}

.well {
padding: var(--wpds-dimension-padding-lg);
border-radius: var(--wpds-border-radius-lg);
background: var(--wpds-color-background-surface-neutral);
border: var(--wpds-border-width-xs) solid var(--wpds-color-stroke-surface-neutral-weak);

@include mixins.settings-well();

font-size: var(--wpds-typography-font-size-md);
line-height: var(--wpds-typography-line-height-sm);
}
9 changes: 5 additions & 4 deletions .../boost/app/assets/src/js/features/image-cdn/quality-settings/quality-settings.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use "$css/main/mixins";

.section-title {
display: flex;
font-weight: 700;
Expand Down Expand Up @@ -32,10 +34,9 @@
}

.well {
padding: var(--wpds-dimension-padding-lg);
border-radius: var(--wpds-border-radius-lg);
background: var(--wpds-color-background-surface-neutral);
border: var(--wpds-border-width-xs) solid var(--wpds-color-stroke-surface-neutral-weak);

@include mixins.settings-well();

font-size: var(--wpds-typography-font-size-md);
line-height: var(--wpds-typography-line-height-sm);
}
Expand Down
7 changes: 3 additions & 4 deletions projects/plugins/boost/app/assets/src/js/features/lcp/status/status.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,13 @@
}

.well {

@include mixins.settings-well();

display: flex;
flex-wrap: wrap;
align-items: center;
gap: var(--wpds-dimension-gap-md);
padding: var(--wpds-dimension-padding-lg);
border-radius: var(--wpds-border-radius-lg);
background: var(--wpds-color-background-surface-neutral);
border: var(--wpds-border-width-xs) solid var(--wpds-color-stroke-surface-neutral-weak);
font-size: var(--wpds-typography-font-size-md);
line-height: var(--wpds-typography-line-height-sm);

Expand Down
8 changes: 5 additions & 3 deletions ...cts/plugins/boost/app/assets/src/js/features/ui/collapsible-meta/except-panel.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
@use "$css/main/mixins";

.panel {
background: var(--wpds-color-background-surface-neutral);
border: var(--wpds-border-width-xs) solid var(--wpds-color-stroke-surface-neutral-weak);
border-radius: var(--wpds-border-radius-lg);

@include mixins.settings-well( $padding: null );

margin-block-end: var(--wpds-dimension-gap-md);

.toggle {
Expand Down
4 changes: 4 additions & 0 deletions projects/plugins/boost/changelog/boost-shared-settings-well
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed
Comment: Share modern Settings well styles without changing their appearance.

Loading