Skip to content

Account Protection: Do not activate by default on new connections - #52715

Draft
bobmatyas wants to merge 1 commit into
trunkfrom
update/account-protection-no-auto-activate
Draft

Account Protection: Do not activate by default on new connections#52715
bobmatyas wants to merge 1 commit into
trunkfrom
update/account-protection-no-auto-activate

Conversation

@bobmatyas

@bobmatyas bobmatyas commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

  • Set the Account Protection module's Auto Activate header to No, so new Jetpack connections, and upgrades from versions before 14.5, no longer turn it on.
  • Stop Jetpack Protect from activating Account Protection when the plugin is activated. Firewall and Brute Force Protection are still activated as before.
  • Existing sites keep their current setting. Neither activation path ever deactivates modules, so sites with Account Protection on stay on, and sites with it off stay off.
  • Add PHPUnit coverage checking that account-protection is not among the default modules for a new connection or for an upgrade from before 14.5.

Closes #52708

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

Automated

  • jetpack docker phpunit jetpack -- --filter Jetpack_Account_Protection_Auto_Activate_Test

Jetpack

  1. On a fresh site that has never been connected, install this branch of Jetpack and connect it.
  2. Go to Jetpack → Settings → Security. Confirm Account Protection is off.
  3. Turn it on and confirm it activates normally.
  4. On an existing site with Account Protection on, update to this branch. Confirm it's still on.
  5. Repeat step 4 with it off. Confirm it stays off.

Jetpack Protect

  1. On a fresh site, install and activate this branch of Jetpack Protect, then connect it.
  2. Confirm the Firewall and Brute Force Protection modules are active and Account Protection is not.
  3. On an existing Protect site with Account Protection on, update to this branch. Confirm it's still on.

Known follow-up (not in this PR): the breached-password notice in packages/account-protection/src/class-password-detection.php says the feature "was automatically activated with a recent Jetpack update", which will no longer be accurate for sites that turn it on manually.

🤖 Generated with Claude Code

@bobmatyas @claude
Account Protection: Do not activate by default on new connections
61494ec 
Set the module's Auto Activate header to No so new Jetpack connections
and upgrades no longer turn it on, and stop Jetpack Protect from
activating it on plugin activation. Existing sites keep their current
setting, since neither activation path deactivates modules.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/account-protection-no-auto-activate branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/account-protection-no-auto-activate

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions Bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress [Tests] Includes Tests labels Sep 23, 2026
@github-actions

github-actions Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: October 6, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Sep 23, 2026
@jp-launch-control

jp-launch-control Bot commented Sep 23, 2026

Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/protect/src/class-jetpack-protect.php 0/182 (0.00%) 0.00% -1 💚

Full summary · PHP report · JS report

@bobmatyas
bobmatyas requested a lite review from Copilot September 23, 2026 15:36
Copilot AI reviewed Sep 23, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved blocking issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Prevents Account Protection from activating automatically for new connections, upgrades, or Jetpack Protect activation while preserving existing settings.

Changes:

  • Sets Auto Activate: No.
  • Removes Protect’s explicit activation.
  • Adds PHPUnit coverage and changelog entries.
File Description
projects/​plugins/​protect/​src/​class-jetpack-protect.php Stops Protect from activating Account Protection.
projects/​plugins/​protect/​changelog/​update-account-protection-no-auto-activate Documents the Protect behavior change.
projects/​plugins/​jetpack/​tests/​php/​general/​Jetpack_Account_Protection_Auto_Activate_Test.php Verifies default module exclusions.
projects/​plugins/​jetpack/​modules/​account-protection.php Disables automatic activation.
projects/​plugins/​jetpack/​changelog/​update-account-protection-no-auto-activate Documents the Jetpack behavior change.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

[Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Tests] Includes Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancement: Disable Account Protection for New Installs + Newly Connected Sites

2 participants

@bobmatyas