Skip to content

Account Protection: Update breached password notice wording - #52993

Open
bobmatyas wants to merge 1 commit into
trunkfrom
update/account-protection-notice-wording
Open

bobmatyas wants to merge 1 commit into
trunkfrom
update/account-protection-notice-wording

Conversation

@bobmatyas

Copy link
Copy Markdown
Contributor

Fixes #

Proposed changes

  • Update the breached password notice shown by Account Protection. It said the feature "was automatically activated with a recent Jetpack update", which stops being accurate once Account Protection: Do not activate by default on new connections #52715 stops activating Account Protection by default. It now reads: "This security feature is enabled on this site to help keep your account safe."
  • Update the matching assertion in Password_Detection_Test.
  • Add changelog entries for the package and for the Jetpack and Jetpack Protect plugins, since site owners of both can see this notice.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

Automated

  • jp test php packages/account-protection

Manual

  1. On a connected Jetpack (or Jetpack Protect) site running this branch, turn on Account Protection under Jetpack → Settings → Security.
  2. Create a user with the Author role or higher, and give it a password that appears in known breaches (for example password123).
  3. Log out, then log in as that user.
  4. On the "password may appear in a known data breach" screen, confirm the second paragraph reads: "This security feature is enabled on this site to help keep your account safe."
  5. Confirm the rest of the screen (verification code email, code entry) works as before.

🤖 Generated with Claude Code

The notice said the feature was activated automatically with a recent
Jetpack update, which is no longer accurate once auto-activation is
removed (#52715).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/account-protection-notice-wording branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/account-protection-notice-wording

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions Bot added [Package] Account Protection [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Tests] Includes Tests labels Sep 30, 2026
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: October 6, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Account Protection [Package] Account Protection [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] Needs Review This PR is ready for review. [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant