Repository navigation
Premium Analytics: call the preview the new Stats in its dialogs - #52722
Conversation
The welcome, feedback and switch-off copy named the Traffic and Insights tabs while those were all the preview had. With Subscribers and Ads joining, every classic tab is in it, so the copy goes back to "the new Stats" rather than growing a list. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Premium Analytics plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
chihsuan
left a comment
There was a problem hiding this comment.
LGTM!
Merge order: after #52720 ships. Merged before it, the invitation would call a two-tab preview "the new Stats".
I think we just need to deploy them together — the merge order itself shouldn’t matter as long as both changes ship at the same time.
Part of the Stats v2 soft launch, alongside #52720.
Proposed changes
The preview's welcome modal, feedback modal and banner, and switch-off dialog name "the new Traffic and Insights tabs" (#52525), which was right while those were the only tabs in the preview. #52720 adds Subscribers and Ads, so every classic Stats tab is in it and the copy goes back to the new Stats instead of growing a list:
[Ready to replace the old Stats? …]prefix on the feedback text.Tests follow the strings. The Calypso side of the invitation (banner, modules menu entry and dialog) is Automattic/wp-calypso#114594.
Merge order: after #52720. Merged before it, the copy would call a two-tab preview "the new Stats".
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
On a site running the preview:
wp user meta delete <id> wp_persisted_preferences) and open Stats. The welcome modal is titled Welcome to the new Stats.jp test js packages/premium-analyticspasses.🤖 Generated with Claude Code